Change BlockBody to use an overloaded constructor with withdrawals #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Frame <jason.frame@consensys.net>
jframe
force-pushed
the
block_withdrawal_parm
branch
from
d4631f6 to
cf5467f
Compare
siladu
approved these changes
Jan 18, 2023
...creation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/AbstractBlockCreator.java
Show resolved
Hide resolved
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…yperledger#4955) Signed-off-by: Jason Frame <jason.frame@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…yperledger#4955) Signed-off-by: Jason Frame <jason.frame@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Change BlockBody to use an overloaded constructor with withdrawals instead having a mandatory
Optional<List<Withdrawals>>as withdrawals are only required for ethereum mainnet.Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog