Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Correct order of args to RequestBody.create #4936

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

macfarla
Copy link
Contributor

Content type moved to second arg where needed to avoid deprecation warning

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@macfarla macfarla added testing dev experience The build system, things that enable easier development etc. labels Jan 16, 2023
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - weird that it was compiling!

Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla enabled auto-merge (squash) January 16, 2023 07:39
@macfarla macfarla merged commit c516829 into hyperledger:main Jan 16, 2023
@macfarla macfarla deleted the requestbody-create branch February 7, 2023 06:16
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
…recation warning (hyperledger#4936)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…recation warning (hyperledger#4936)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev experience The build system, things that enable easier development etc. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants