Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdrawals processor #4917

Merged
merged 16 commits into from
Jan 16, 2023
Merged

Withdrawals processor #4917

merged 16 commits into from
Jan 16, 2023

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Jan 13, 2023 •
edited
Loading

PR description

Process withdrawals when creating a block and when processing a block. Withdrawals processing is only enabled for the shanghai fork and beyond.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

jframe added 6 commits January 9, 2023 17:39
@jframe
Process withdrawals
e04b71c 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Only allow withdrawals processing when shanghai is enabled
1f086b3 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Withdrawals processor tests
99bf7e4 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
block creator and block processor tests
0d2c029 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Merge remote-tracking branch 'upstream/main' into withdrawals_processor
0947412
@jframe
Missing javadoc for BlockProcessor
24748b4 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe jframe marked this pull request as ready for review January 13, 2023 06:13
macfarla
macfarla reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible to me

@jframe
Copy link
Contributor Author

jframe commented Jan 16, 2023

Just thinking that PoW will rerun AbstractBlockCreatorTest's tests as well as the parent I think - is that the intention?

Potentially could make AbstractBlockCreatorTest abstract so they run for subclasses but not the parent
Good point would be better to make this abstract

jframe added 7 commits January 16, 2023 13:00
@jframe
Code review changes
8f3b630 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Merge remote-tracking branch 'upstream/main' into withdrawals_processor
9052432
@jframe
Fix compile error after main merge
20a3910 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Update engine API tests to work with withdrawals changes
16e53f9 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
spotless
d2497d8 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Change ProtocolSpec return Optional<WithdrawalProcessor>
fe2d63c 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Merge branch 'main' into withdrawals_processor
29a1eb6
@jframe jframe enabled auto-merge (squash) January 16, 2023 20:56
@jframe jframe merged commit e89b773 into hyperledger:main Jan 16, 2023
@jframe jframe deleted the withdrawals_processor branch January 16, 2023 21:35
@jframe jframe added the TeamGroot GH issues worked on by Groot Team label Jan 18, 2023
@garyschulte garyschulte mentioned this pull request Apr 15, 2023
Merged
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@jframe @elenduuche
Withdrawals processor (hyperledger#4917)
b1384c6 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@jframe @eum602
Withdrawals processor (hyperledger#4917)
0e09ee3 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla left review comments

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
TeamGroot GH issues worked on by Groot Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jframe @macfarla @siladu