EOF Optimization - don't split code sections #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize the EOF Functions implementation by not splitting code sections into separate Bytes object. Instead the EOF evaluation occurs on a single container space. When a function is called the PC (relative to container start, not section start) is moved. EOF lacks PC introspection and absolute jumps, so where "PC=0" starts is not observable to the code. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| workList[maxWork] = new int[] {currentPC + rvalue + 3, currentStackHeight}; | ||
| maxWork++; | ||
| } else if (thisOp == RelativeJumpVectorOperation.OPCODE) { | ||
| int immediateDataSize = (code[currentPC + 1] & 0xff) * 2; |
Check failure
Code scanning / CodeQL
Array index out of bounds
macfarla
changed the title
jflo
approved these changes
Jan 11, 2023
|
(a) memory usage. We don't have to slice out code sections and make copies of the sections. Also a bit of speed on the parse |
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
|
(c) there is also a runtime performance improvement, as we don't have to swap code sections in and out at function calls, but instead it's just a jump with more rules. |
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Optimize the EOF Functions implementation by not splitting code sections into separate Bytes object. Instead the EOF evaluation occurs on a single container space. When a function is called the PC (relative to container start, not section start) is moved. EOF lacks PC introspection and absolute jumps, so where "PC=0" starts is not observable to the code. "PC=0" is still respected in the traces. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Optimize the EOF Functions implementation by not splitting code sections into separate Bytes object. Instead the EOF evaluation occurs on a single container space. When a function is called the PC (relative to container start, not section start) is moved, and no section re-loading needs to occur.
EOF lacks PC introspection and absolute jumps, so where "PC=0" starts is not observable to the code.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog