Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCO check on main #4847

Merged
merged 5 commits into from
Dec 21, 2022
Merged

DCO check on main #4847

merged 5 commits into from
Dec 21, 2022

Conversation

macfarla
Copy link
Contributor

fixes #4837

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@@ -1,5 +1,7 @@
name: dco
on:
push:
branches: [ main ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include releases as well in case we create release branches?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit fa9f99d into hyperledger:main Dec 21, 2022
jflo pushed a commit to jflo/besu that referenced this pull request Dec 22, 2022
* run dco on push to main

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* release branches

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* add test-dco* branch

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@macfarla macfarla mentioned this pull request Jan 9, 2023
2 tasks
@macfarla macfarla removed the mainnet label Jan 9, 2023
@macfarla macfarla deleted the dco-main branch January 9, 2023 05:45
macfarla added a commit to macfarla/besu that referenced this pull request Jan 10, 2023
* run dco on push to main

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* release branches

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* add test-dco* branch

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* run dco on push to main

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* release branches

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* add test-dco* branch

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DCO Check Github Action
3 participants