Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gabriel Fukushima as a maintainer #4750

Merged
merged 4 commits into from
Dec 7, 2022

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Nov 30, 2022

Signed-off-by: Jason Frame jason.frame@consensys.net

PR description

Proposing @gfukushima as a new Besu maintainer. They have made over 5 significant commits that have improved the quality of Besu and/or added new features.

Voting ends 2 weeks from the publication of this PR or once more than 50% of the current maintainers approve.

For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: Jason Frame <jason.frame@consensys.net>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jason Frame <jason.frame@consensys.net>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ahamlat
Copy link
Contributor

ahamlat commented Dec 1, 2022

👍

Copy link
Contributor

@mark-terry mark-terry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@garyschulte
Copy link
Contributor

seems to me this should be set to auto-merge. With the original author, I count 13 of 24

@garyschulte
Copy link
Contributor

ah, @ahamlat - you only commented. You didn't "approve"

@jframe jframe merged commit efa0a75 into hyperledger:main Dec 7, 2022
@jframe jframe deleted the gfukushima_maintainer branch December 7, 2022 23:31
Gabriel-Trintinalia pushed a commit to Gabriel-Trintinalia/besu that referenced this pull request Dec 8, 2022
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
ahamlat pushed a commit to ahamlat/besu that referenced this pull request Dec 18, 2022
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
@shemnon shemnon mentioned this pull request Dec 19, 2022
macfarla pushed a commit to jflo/besu that referenced this pull request Jan 10, 2023
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.