Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type field to eth_getTransactionReceipt #4713

Conversation

Gabriel-Trintinalia
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia commented Nov 21, 2022

Signed-off-by: Gabriel Trintinalia gabriel.trintinalia@gmail.com

PR description

Add type field to eth_getTransactionReceipt according to: https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_gettransactionreceipt

type: DATA - integer of the transaction type, 0x00 for legacy transactions, 0x01 for access list types, 0x02 for dynamic fees.

Fixed Issue(s)

fixes #4505

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Needs to be updated:

besu-docs PR:
hyperledger/besu-docs#1205

Changelog

Gabriel-Trintinalia and others added 2 commits November 21, 2022 15:53
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
@Gabriel-Trintinalia Gabriel-Trintinalia self-assigned this Nov 21, 2022
@Gabriel-Trintinalia Gabriel-Trintinalia added the TeamRevenant GH issues worked on by Revenant Team label Nov 21, 2022
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review November 21, 2022 05:50
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog? add a note that this is part of eth/68

@Gabriel-Trintinalia Gabriel-Trintinalia added the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 21, 2022
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 7d374b6 into hyperledger:main Nov 21, 2022
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the 4505-add-type-transaction-receipt branch November 21, 2022 09:03
@rolandtyler rolandtyler removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 21, 2022
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Nov 21, 2022
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Nov 21, 2022
Signed-off-by: garyschulte <garyschulte@gmail.com>
macfarla pushed a commit to macfarla/besu that referenced this pull request Jan 10, 2023
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mainnet TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_getTransactionReceipt missing type field
3 participants