Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to debug the potential problems with closing Transaction #4654

Merged
merged 2 commits into from
Nov 12, 2022

Conversation

gezero
Copy link
Contributor

@gezero gezero commented Nov 11, 2022

If we are adding finalize, at least add some way to investigate a potential not closed object.

Signed-off-by: Jiri Peinlich jiri.peinlich@gmail.com

@gezero gezero force-pushed the add-printing-of-stacktraces branch from 6ee3808 to 43f709d Compare November 11, 2022 11:08
@garyschulte garyschulte force-pushed the add-printing-of-stacktraces branch from edd2806 to 0c63896 Compare November 12, 2022 19:12
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change to use debugLambda, 🚢

@garyschulte garyschulte enabled auto-merge (squash) November 12, 2022 19:13
@garyschulte garyschulte force-pushed the add-printing-of-stacktraces branch from 0c63896 to e531187 Compare November 12, 2022 19:42
gezero and others added 2 commits November 12, 2022 12:14
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
…bug is not enabled

Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte force-pushed the add-printing-of-stacktraces branch from e531187 to 0871d69 Compare November 12, 2022 20:14
@garyschulte garyschulte merged commit 2528aac into hyperledger:main Nov 12, 2022
wcgcyx pushed a commit to wcgcyx/besu that referenced this pull request Nov 16, 2022
hyperledger#4654)

* Adding option to debug the potential problems with closing Transaction

Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Co-authored-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: wcgcyx <wcgcyx@gmail.com>
macfarla pushed a commit to macfarla/besu that referenced this pull request Jan 10, 2023
hyperledger#4654)

* Adding option to debug the potential problems with closing Transaction

Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Co-authored-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
hyperledger#4654)

* Adding option to debug the potential problems with closing Transaction

Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Co-authored-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants