Implement eth/67 sub protocol (EIP-4938) #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
… mocked Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
…tinalia/besu into 4596-eth67-protocol
Gabriel-Trintinalia
changed the title
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
macfarla
reviewed
Nov 15, 2022
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthProtocolManager.java
Show resolved
Hide resolved
...reum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/manager/EthProtocolManagerTest.java
Show resolved
Hide resolved
macfarla
approved these changes
Nov 15, 2022
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthProtocolManager.java
Show resolved
Hide resolved
jframe
approved these changes
Nov 16, 2022
| // Fast sync depends on GetNodeData and NodeData | ||
| // Do not add eth/67 if fast sync is enabled | ||
| // see https://eips.ethereum.org/EIPS/eip-4938 | ||
| if (!Objects.equals(SyncMode.FAST, synchronizerConfiguration.getSyncMode())) { |
There was a problem hiding this comment.
Curious to know why you are using Object.equals instead of just doing SyncMode.FAST == synchronizerConfiguration.getSyncMode()
diega
approved these changes
Nov 16, 2022
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@gmail.com>
gfukushima
added a commit
to gfukushima/besu
that referenced
this pull request
Nov 29, 2022
This reverts commit 7c35be3.
macfarla
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 10, 2023
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gabriel Trintinalia gabriel.trintinalia@gmail.com
PR description
eth/67 (EIP-4938, March 2022)
Version 67 removed the GetNodeData and NodeData messages.
Besu:
Fixed Issue(s)
fixes #4596
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog