♻️ Refactor EthProtocol to externalise EthVersion into its own class #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge types Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net>
macfarla
approved these changes
Nov 9, 2022
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright ConsenSys AG. | |||
| * Copyright contributors to Hyperledger Besu | |||
There was a problem hiding this comment.
nit: we don't need to change the copyright for existing files. (not sure it's worth changing back though)
wcgcyx
pushed a commit
to wcgcyx/besu
that referenced
this pull request
Nov 16, 2022
…yperledger#4640) Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: wcgcyx <wcgcyx@gmail.com>
macfarla
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 10, 2023
…yperledger#4640) Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…yperledger#4640) Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net> Co-authored-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Refactor EthProtocol to externalise EthVersion into its own class to improve readability
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog