Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 22.7.7 #4545

Merged
merged 8 commits into from
Oct 19, 2022
Merged

Release 22.7.7 #4545

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
35edb60
The block variable was keeping too much memory while waiting for futu…
gezero Oct 6, 2022
ac7832a
Reduce the number of runtime exceptions (SecurityModuleException) (#4…
ahamlat Oct 19, 2022
91511fa
Upgrade Apache Commons Text to 1.10.0 (#4542)
daniellehrner Oct 19, 2022
b46ebcf
Tune EthScheduler thread pools to avoid to recreate too many threads …
fab-10 Oct 13, 2022
694fd1e
Make GraphQL scalar parsing compatible with variables (#4522)
shemnon Oct 12, 2022
75b07b6
don't add to bad blocks manager on StorageException (#4524)
jflo Oct 13, 2022
df235cc
CHANGELOG for 22.7.7
fab-10 Oct 19, 2022
71c8cef
Release 22.7.7
fab-10 Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tune EthScheduler thread pools to avoid to recreate too many threads (#… 
…4529)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
  • Loading branch information
@fab-10
fab-10 committed Oct 19, 2022
commit b46ebcf2f0c7a31e4610334b74662d0e13ab7adf
3 changes: 2 additions & 1 deletion ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/EthScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,12 @@ public EthScheduler(
final MetricsSystem metricsSystem) {
this(
MonitoredExecutors.newFixedThreadPool(
EthScheduler.class.getSimpleName() + "-Workers", syncWorkerCount, metricsSystem),
EthScheduler.class.getSimpleName() + "-Workers", 1, syncWorkerCount, metricsSystem),
MonitoredExecutors.newScheduledThreadPool(
EthScheduler.class.getSimpleName() + "-Timer", 1, metricsSystem),
MonitoredExecutors.newBoundedThreadPool(
EthScheduler.class.getSimpleName() + "-Transactions",
1,
txWorkerCount,
txWorkerQueueSize,
metricsSystem),
Expand Down
14 changes: 9 additions & 5 deletions ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/manager/MonitoredExecutors.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,20 @@
public class MonitoredExecutors {

public static ExecutorService newFixedThreadPool(
final String name, final int workerCount, final MetricsSystem metricsSystem) {
return newFixedThreadPool(name, 0, workerCount, new LinkedBlockingQueue<>(), metricsSystem);
final String name,
final int minWorkerCount,
final int workerCount,
final MetricsSystem metricsSystem) {
return newFixedThreadPool(
name, minWorkerCount, workerCount, new LinkedBlockingQueue<>(), metricsSystem);
}

public static ExecutorService newBoundedThreadPool(
final String name,
final int workerCount,
final int queueSize,
final MetricsSystem metricsSystem) {
return newBoundedThreadPool(name, 0, workerCount, queueSize, metricsSystem);
return newBoundedThreadPool(name, 1, workerCount, queueSize, metricsSystem);
}

public static ExecutorService newBoundedThreadPool(
Expand Down Expand Up @@ -77,8 +81,8 @@ private static ExecutorService newFixedThreadPool(
new ThreadPoolExecutor(
minWorkerCount,
maxWorkerCount,
0L,
TimeUnit.MILLISECONDS,
60L,
TimeUnit.SECONDS,
workingQueue,
threadFactory,
rejectedExecutionHandler));
Expand Down