don't add to bad blocks manager on StorageException #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
macfarla
reviewed
Oct 12, 2022
| badBlockManager.addBadBlock(invalidBlock); | ||
| if (!result.internalError()) { | ||
| badBlockManager.addBadBlock(invalidBlock); | ||
| } |
There was a problem hiding this comment.
TODidit, now its TODOne
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
fab-10
pushed a commit
to fab-10/besu
that referenced
this pull request
Oct 19, 2022
* don't add to bad blocks manager on StorageException * add bugfix to changelog * adds test coverage Signed-off-by: Justin Florentine <justin+github@florentine.us>
fab-10
added a commit
that referenced
this pull request
Oct 19, 2022
* The block variable was keeping too much memory while waiting for future to finish (#4489) Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * Reduce the number of runtime exceptions (SecurityModuleException) (#4508) * During handshake, flip the encrypted message decryption by starting with the new format (EIP-8), and if there is an exception, try the old format. This will reduce the number of exceptions and unnecessary executions. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * update CHANGELOG.md to give more context on this PR. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * update CHANGELOG.md to give more context on this PR. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Delete some debug code committed by error Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: ahamlat <ameziane.hamlat@consensys.net> * Upgrade Apache Commons Text to 1.10.0 (#4542) * upgraded Apache Commons Text to fix CVE-2022-42889 Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * add changelog Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com> * Tune EthScheduler thread pools to avoid to recreate too many threads (#4529) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Make GraphQL scalar parsing compatible with variables (#4522) Our current GraphQL scalar parsing interacts poorly with the variables support in the library. Revise the parsing so it works correctly. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> * don't add to bad blocks manager on StorageException (#4524) * don't add to bad blocks manager on StorageException * add bugfix to changelog * adds test coverage Signed-off-by: Justin Florentine <justin+github@florentine.us> * CHANGELOG for 22.7.7 Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Release 22.7.7 Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: ahamlat <ameziane.hamlat@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Jiri Peinlich <jiri.peinlich@gmail.com> Co-authored-by: ahamlat <ameziane.hamlat@consensys.net> Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* don't add to bad blocks manager on StorageException * add bugfix to changelog * adds test coverage Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Florentine justin+github@florentine.us
PR description
Fixes issue where Besu records a block that experienced a StorageException as a bad block, thus preventing it from being retried by the Consensus Layer. Also corrects some response handling which was hiding the issue.
Fixed Issue(s)
fixes #4512
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog