Log index is counted per block, not per transaction #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
fab-10
reviewed
Sep 9, 2022
| isQueryAlive); | ||
| final boolean removed = getRemoved(blockHash, isQueryAlive); | ||
|
|
||
| final AtomicInteger logIndexOffset = new AtomicInteger(); |
There was a problem hiding this comment.
Why an AtomicInteger here? it seems that a plain int is enough
| @@ -83,16 +84,24 @@ public List<LogWithMetadata> matchingLogs( | |||
| final long blockNumber = blockHeader.get().getNumber(); | |||
| final boolean removed = !blockchainQueries.blockIsOnCanonicalChain(blockHash); | |||
|
|
|||
| final AtomicInteger logIndexOffset = new AtomicInteger(); | |||
...edger/besu/ethereum/api/jsonrpc/websocket/subscription/logs/LogsSubscriptionServiceTest.java
Outdated
Show resolved
Hide resolved
|
Please update the CHANGELOG |
fab-10
approved these changes
Oct 4, 2022
Signed-off-by: mark-terry <mark.terry@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Log index is counted per block, not per transaction Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: mark-terry <mark.terry@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Lehrner daniel.lehrner@consensys.net
PR description
The log index returned by
eth_getLogsis currently counted on a transaction basis, which is incorrect. The correct way is to have it unique per block. This PR changes it to the correct behavior.Fixed Issue(s)
fixes #4114
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog