Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup from PR 4178 #4266

Merged
merged 8 commits into from
Sep 4, 2022
Merged

cleanup from PR 4178 #4266

merged 8 commits into from
Sep 4, 2022

Conversation

pinges
Copy link
Contributor

@pinges pinges commented Aug 16, 2022

Signed-off-by: Stefan stefan.pingel@consensys.net

PR description

This PR fixes some issues based n comments against #4178

pinges added 2 commits August 17, 2022 08:48
Signed-off-by: Stefan <stefan.pingel@consensys.net>
@pinges pinges requested review from mbaxter and garyschulte August 18, 2022 01:50
@pinges pinges marked this pull request as ready for review August 23, 2022 04:13
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinges pinges merged commit a5bf37c into hyperledger:main Sep 4, 2022
@pinges pinges deleted the ReviewComments4178 branch September 4, 2022 23:58
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Stefan <stefan.pingel@consensys.net>
Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants