Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MergeUnfinalizedValidationRule #4240

Conversation

garyschulte
Copy link
Contributor

PR description

The CL is allowed to reorg around finalized via social consensus. Remove this validation rule and rely solely on the CL for that social coordination.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

…o execute a reorg around an already finalized block.

Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte changed the title remove MergeUnfinalizedRule remove MergeUnfinalizedValidationRule Aug 9, 2022
Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"trust the process"

@garyschulte garyschulte enabled auto-merge (squash) August 9, 2022 18:48
@garyschulte garyschulte merged commit f43b9ad into hyperledger:main Aug 9, 2022
@garyschulte garyschulte deleted the bugfix/remove-merge-unfinalized-rule branch August 9, 2022 19:55
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…o execute a reorg around an already finalized block. (hyperledger#4240)

Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants