correct fallback ttd to correct value #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Aug 8, 2022
* correct fallback ttd to correct value Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Aug 8, 2022
* correct fallback ttd to correct value Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Cody Born <codyborn@outlook.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* correct fallback ttd to correct value Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Lehrner daniel.lehrner@consensys.net
PR description
The fallback TTD for mainnet had off-by-one error. We need to set it to
2^256 - 2^10, but our code wasThe problem is that
MAX_VALUEis2^256 - 1, not2^256. So we were calculating in the end2^256 - 1 - 2^10.This PR replaces the calculation with the hard coded value as hex in the config and as decimal in the test.
I confirmed the value with the mainnet genesis file for the consensus clients: https://github.com/ethereum/consensus-specs/blob/981b05afb01d5b19be3a5a60ccb12c3582e4c0cf/configs/mainnet.yaml#L16
Fixed Issue(s)
fixes #4220
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog