jwt auth on websockets #4039
Merged
jwt auth on websockets #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Florentine <justin+github@florentine.us>
…ccessful Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
force-pushed
the
3990-jwt-on-websockets
branch
from
bae8c5f to
fd3f980
Compare
Signed-off-by: Justin Florentine <justin+github@florentine.us>
garyschulte
reviewed
Jul 1, 2022
| import com.fasterxml.jackson.annotation.JsonSetter; | ||
|
|
||
| @JsonPropertyOrder({"jsonrpc", "id", "result"}) | ||
| public class MutableJsonRpcSuccessResponse { |
There was a problem hiding this comment.
can this be moved to src/test ? It looks like it is only used as a deserialization target in tests
Signed-off-by: Justin Florentine <justin+github@florentine.us>
garyschulte
added a commit
that referenced
this pull request
Jul 7, 2022
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
added a commit
that referenced
this pull request
Jul 7, 2022
49e4fd8 -> worldstate not avail (#4069) 6aa8812 -> stateroot mismatch (#4041) 043191a -> jwt auth on websockets (#4039) 90f891b -> do not move head on exec and propose (#4013) 3baa4da -> upgrade for websockets (#4019) 5024c07 -> sepolia TTD (#4024) 5ee9be8 -> heal step in snap (#3920) 261b1e0 -> remove peer block height requirements (#3911) Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
added a commit
that referenced
this pull request
Jul 7, 2022
49e4fd8 -> worldstate not avail (#4069) 6aa8812 -> stateroot mismatch (#4041) 043191a -> jwt auth on websockets (#4039) 90f891b -> do not move head on exec and propose (#4013) b5fa62c -> sync check before processing remote transactions (4035) 3baa4da -> upgrade for websockets (#4019) 5024c07 -> sepolia TTD (#4024) 5ee9be8 -> heal step in snap (#3920) 261b1e0 -> remove peer block height requirements (#3911) Signed-off-by: garyschulte <garyschulte@gmail.com>
Merged
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* integration test covering websocket subscription without auth * uses authenticated user on websocket handler when auth enabled and successful * sonarlint fixes and copyright correction * moved test specific class to test sources Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3990