Extend block parameter methods to accept 'finalized' and 'safe' as block tags #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock tags Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
get_block_finalized_safe
branch
from
337e94e to
c8b0d8e
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
added
doc-change-required
shemnon
approved these changes
Jun 9, 2022
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Additions and Improvements | |||
| - \[EXPERIMENTAL\] Add checkpoint sync `--sync-mode="X_CHECKPOINT"` [#3849](https://github.com/hyperledger/besu/pull/3849) | |||
| - Support `latest` and `safe` as tags for the block parameter in RPC APIs [#3950](https://github.com/hyperledger/besu/pull/3950) | |||
| // If block parameter is not numeric or latest, it is pending. | ||
| result = pendingResult(request); | ||
| return resultByBlockNumber(request, blockNumber.get()); | ||
| } |
There was a problem hiding this comment.
Style wise these should remain if/else chained. They are not proper "guard blocks" and readability would be improved by retaining the if/elseif/elseif chain. Bringing in the last return as an else would further improve the readability.
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
shemnon
approved these changes
Jun 9, 2022
callree
reviewed
Jun 9, 2022
what do you mean? |
rolandtyler
removed
the
doc-change-required
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…ock tags (hyperledger#3950) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Fixed Issue(s)
fixes #3947
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog