Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt to fix QosTimerTest #3876

Merged
merged 2 commits into from
May 20, 2022
Merged

attempt to fix QosTimerTest #3876

merged 2 commits into from
May 20, 2022

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented May 20, 2022 •
edited
Loading

Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net

Test has been flaky. This is a refactor aiming to fix flakiness.
Refactor extracted from #3850 courtesy @diega

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@macfarla
attempt to fix QosTimerTest
9b4e78c 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
jframe
jframe approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe enabled auto-merge (squash) May 20, 2022 04:30
@jframe jframe merged commit 383eb9b into hyperledger:main May 20, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@macfarla macfarla deleted the qos-timer-test branch May 20, 2022 07:30
sharad-develop pushed a commit to sharad-develop/besu that referenced this pull request May 27, 2022
@macfarla @jframe @sharad-develop
attempt to fix QosTimerTest (hyperledger#3876)
cf9e51a 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Co-authored-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Sharad Gulati <sharad.develop@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @jframe @eum602
attempt to fix QosTimerTest (hyperledger#3876)
0af7ed7 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Co-authored-by: Jason Frame <jasonwframe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @jframe