Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settle down panda #3844

Merged
merged 2 commits into from
May 17, 2022
Merged

settle down panda #3844

merged 2 commits into from
May 17, 2022

Conversation

jflo
Copy link
Contributor

@jflo jflo commented May 17, 2022

Signed-off-by: Justin Florentine justin+github@florentine.us

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. could add a test?

@macfarla macfarla enabled auto-merge (squash) May 17, 2022 01:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@macfarla macfarla merged commit b53aa3a into hyperledger:main May 17, 2022
sharad-develop pushed a commit to sharad-develop/besu that referenced this pull request May 27, 2022
Signed-off-by: Justin Florentine <justin+github@florentine.us>

Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sharad Gulati <sharad.develop@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Justin Florentine <justin+github@florentine.us>

Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants