Fcu verify payload attributes #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e one of the head block Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
daniellehrner
force-pushed
the
fcu_verify_payload_attributes
branch
from
44455b6 to
8cacabf
Compare
fab-10
reviewed
Jun 7, 2022
...g/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineForkchoiceUpdated.java
Outdated
Show resolved
Hide resolved
Comment on lines
118
to
122
| if (optionalPayloadAttributes.isPresent() | ||
| && !isPayloadAttributesValid(optionalPayloadAttributes.get(), newHead.get())) { | ||
| return new JsonRpcErrorResponse(requestId, JsonRpcError.INVALID_PAYLOAD_ATTRIBUTES); | ||
| } | ||
|
|
There was a problem hiding this comment.
I have a doubt, since #3836 says:
Invalid payload attributes and MUST NOT begin a payload build process. In such an event, the forkchoiceState update MUST NOT be rolled back.
my understanding is that, even if there are payload attribute errors, the FcU should be applied, but the error is returned before the mergeCoordinator.updateForkChoice call, so the FcU update is never applied, or am I missnig something?
There was a problem hiding this comment.
Yes, after further investigation that is how it should work. I've changed the code accordingly
|
Please add a CHANGELOG entry |
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
fab-10
requested changes
Jun 8, 2022
...g/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineForkchoiceUpdated.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
fab-10
approved these changes
Jun 10, 2022
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* check that the timestamp in fcu payload attributes is greater than the one of the head block Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds payload attributes checks to EngineForkchoiceUpdated and returns INVALID_PAYLOAD_ATTRIBUTES error if any of them should be invalid.
Fixed Issue(s)
"fixes #3836 "
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog