Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safe rocksdb segment handles #3734

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Apr 15, 2022

PR description

Ensure thread-safe access to rocksdb column family segments, in case we have dropped and recreated a columnFamily in RocksDBColumnarKeyValueStorage.clear().

Fixed Issue(s)

#3722

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@garyschulte garyschulte marked this pull request as ready for review April 15, 2022 21:01
…ference closed handles

Signed-off-by: garyschulte <garyschulte@gmail.com>
@jflo jflo force-pushed the bugfix-3722-columnfamily-segfault-on-closed branch from 86a2e10 to ff125db Compare April 22, 2022 13:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@garyschulte garyschulte merged commit 23f5e2e into hyperledger:main Apr 22, 2022
@garyschulte garyschulte deleted the bugfix-3722-columnfamily-segfault-on-closed branch April 22, 2022 15:43
garyschulte added a commit to garyschulte/besu that referenced this pull request May 2, 2022
…ference closed handles (hyperledger#3734)

Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…ference closed handles (hyperledger#3734)

Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants