Use JUnit 5 for unit test execution #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the unit test execution to use the Junit5 JUnitPlatform. This allows for a mix of junit 4 and junit 5 tests and for a gradual migration to junit 5 instead of a big bang. One class depended on junit 4 exceptions and was updated. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
fab-10
approved these changes
Mar 22, 2022
gezero
approved these changes
Mar 22, 2022
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
diega
approved these changes
Mar 23, 2022
macfarla
approved these changes
Mar 31, 2022
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Apr 7, 2022
Change the unit test execution to use the Junit5 JUnitPlatform. This allows for a mix of junit 4 and junit 5 tests and for a gradual migration to junit 5 instead of a big bang. One class depended on junit 4 exceptions and was updated. Two tests depending on native libraries fail gracefully on mac (and only mac). Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
May 2, 2022
Change the unit test execution to use the Junit5 JUnitPlatform. This allows for a mix of junit 4 and junit 5 tests and for a gradual migration to junit 5 instead of a big bang. One class depended on junit 4 exceptions and was updated. Two tests depending on native libraries fail gracefully on mac (and only mac). Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Change the unit test execution to use the Junit5 JUnitPlatform. This allows for a mix of junit 4 and junit 5 tests and for a gradual migration to junit 5 instead of a big bang. One class depended on junit 4 exceptions and was updated. Two tests depending on native libraries fail gracefully on mac (and only mac). Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Change the unit test execution to use the Junit5 JUnitPlatform. This
allows for a mix of junit 4 and junit 5 tests and for a gradual
migration to junit 5 instead of a big bang. One class depended on
junit 4 exceptions and was updated.
Also, this facilitated a slight refactor of TLSContextFactoryTest so
that when running on a mac (typical developer machine) errors stemming
from the nss3 library do not cause unit test failures, while still
testing non-nss3 code paths. Tests will perform normally in integration.
Changelog