trace_rawTransaction #3459

macfarla · 2022-02-18T05:08:43Z

Json RPC endpoint and test files for trace_rawTransaction

Changelog

I thought about the changelog and included a changelog update if required.

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

…nsaction

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

…nsaction

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

…nsaction

frankisawesome

Looks good! Left some fairly minor comments and suggestions

...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TraceRawTransaction.java

…nsaction

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Signed-off-by: Frank Li <b439988l@gmail.com>

...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TraceRawTransaction.java

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

…nsaction

the stray TODO comment has been removed. resolved.

… trace-raw-transaction

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

pinges · 2022-03-07T02:57:18Z

...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TraceRawTransaction.java

+    final Transaction transaction;
+    try {
+      transaction = DomainObjectDecodeUtils.decodeRawTransaction(rawTransaction);
+      LOG.trace("Received raw transaction {}", transaction);


I've had a very quick look at what/if we are logging RPC methods. It might be worth creating a ticket to have a consistent approach to that.

What level of logging (Is trace level the right level?)

What are we logging? params? Just the name of the called method? Just the most important params, like here?

pinges · 2022-03-07T03:00:09Z

...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TraceRawTransaction.java

+    }
+
+    final TraceTypeParameter traceTypeParameter =
+        requestContext.getRequiredParameter(1, TraceTypeParameter.class);


If we do get an invalid parameter here, do we return a meaningful error?

You'll see this message at DEBUG level

at org.hyperledger.besu.ethereum.api.jsonrpc.JsonRpcHttpService.lambda$handleJsonSingleRequest$14(JsonRpcHttpService.java:610) at io.vertx.core.impl.ContextImpl.lambda$null$0(ContextImpl.java:159) at io.vertx.core.impl.AbstractContext.dispatch(AbstractContext.java:100) at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$1(ContextImpl.java:157) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: com.fasterxml.jackson.databind.exc.ValueInstantiationException: Cannot construct instance of `org.hyperledger.besu.ethereum.api.jsonrpc.internal.parameters.TraceTypeParameter`, problem: Invalid trace types supplied: boo, foo at [Source: (String)"["boo","foo"]"; line: 1, column: 13]

...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TraceRawTransaction.java

…nsaction

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

… trace-raw-transaction

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

…nsaction

pinges

LGTM

sonarqubecloud · 2022-03-07T05:39:25Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

79.2% Coverage
0.0% Duplication

* Json RPC endpoint and test files for trace_rawTransaction * cache the block number to make sure we are using the same block Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Co-authored-by: Frank Li <b439988l@gmail.com> Co-authored-by: MadelineMurray <43356962+MadelineMurray@users.noreply.github.com>

* Prepare fo release 22.1.2 Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> * remove orion refs (#3494) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Handle TTD and mining pre and post merge (#3486) * handle TTD and mining pre and post merge without creating a regression in behavior for clique networks Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Reject locally-sourced transactions below the minimum gas price when not mining (#3397) * Refactor TransactionPool to accept MiningParameters * Check for zero GasPrice Frontier Transactions * if you are not mining your node could fill up with pending transactions. * make low-or-no-gas transactions viable for local transactions Signed-off-by: Antony Denyer <git@antonydenyer.co.uk> Co-authored-by: garyschulte <garyschulte@gmail.com> * 3378 ws engine (#3493) * implements execution engine APIs over websockets Signed-off-by: Justin Florentine <justin+github@florentine.us> * QBFT Migration: allow active mining coordinator to be shutdown (#3438) Call the shutdown task async to allow the BftProcessor CountDownLatch to complete. Start the next coordinator only once the previous shutdown is complete. Fixes #3003 Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> * to remove deprecated proto dependency, needed to add jaeger-proto dependency (#3485) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Rename field random to prevRandao (#3495) * rename field random to prevRandao Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Improve contract validation errors (#3499) For each contract validation error return a relevant error instead of the incorrect "INSUFFICIENT_GAS" error. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> * Update ef bootnodes (#3502) * update ef bootnodes Signed-off-by: Frank Li <b439988l@gmail.com> * fix typo in bootnode Signed-off-by: Frank Li <b439988l@gmail.com> * update mainnet config Signed-off-by: Frank Li <b439988l@gmail.com> * Add GitHub action to verify gradle-wrapper.jar (#3503) Checks that the gradle wrapper jar is from an official release. See https://github.com/gradle/wrapper-validation-action for more details. Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net> * Bugfix/terminal block check (#3501) * speculative use of backward sync in forkchoiceupdated * reorg newPayload tests to not return INVALID_TERMINAL_BLOCK for as-yet-unknown parent hashes Signed-off-by: garyschulte <garyschulte@gmail.com> * Refactor trace api methods (#3510) * abstract trace classes Signed-off-by: Frank Li <b439988l@gmail.com> * add spdx headers Signed-off-by: Frank Li <b439988l@gmail.com> * FullSync Future should stop when total terminal difficulty is reached (#3423) * FullSync Future should stop when total terminal difficulty is reached Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * [MINOR] typo in resource class (#3516) * medium Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * typo Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * debug_accountAt - fixed issue with contract code (#3518) * fixed bug with contract code > 32 bytes Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * move Vijay to emeritus (#3514) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * trace_get (#3477) * Initial commit for trace_get implementation. No tests. * test files for trace_get Signed-off-by: Mark Terry <mark.terry@consensys.net> Signed-off-by: Frank Li <b439988l@gmail.com> Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> Co-authored-by: Frank Li <b439988l@gmail.com> Signed-off-by: Frank Li <b439988l@gmail.com> * [MINOR] addressed some sonar code smells (#3520) * addressed some sonar code smells Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * updated several dependencies (#3523) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Log initial sync stats every 10 secs at max to avoid spamming logs (#3525) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Updated dependencies including log4j (#3529) * updated some more dependencies * changed errorprone back Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * upgrade vertx (#3530) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * trace_rawTransaction (#3459) * Json RPC endpoint and test files for trace_rawTransaction * cache the block number to make sure we are using the same block Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Co-authored-by: Frank Li <b439988l@gmail.com> Co-authored-by: MadelineMurray <43356962+MadelineMurray@users.noreply.github.com> * Feature/trace callmany (#3468) * unit test + working code + test spec files Signed-off-by: Frank Li <b439988l@gmail.com> Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net> Co-authored-by: Frank Li <b439988l@gmail.com> Signed-off-by: Frank Li <b439988l@gmail.com> * add trace_callMany to CHANGELOG (#3531) Signed-off-by: Stefan Pingel <stefan.pingel@consensys.net> Signed-off-by: Frank Li <b439988l@gmail.com> * 3465 jwt auth (#3508) * refactored auth to allow variant JWT rules to be adopted by different stacks * configures JWT secret from a file, or creates a temporary one * jwt auth is optional for engine apis * test coverage of new cli options Signed-off-by: Justin Florentine <justin+github@florentine.us> * [Issue 3115] Support mining beneficiary transitions (#3505) Signed-off-by: Meredith Baxter <meredith.baxter@palm.io> Signed-off-by: Frank Li <b439988l@gmail.com> * MERGE: engine_exchangeTransitionConfigurationV1 API (#3473) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: garyschulte <garyschulte@gmail.com> * docker executor (#3535) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Co-authored-by: Frank Li <b439988l@gmail.com> * Trace APIs: add revert reason (#3539) * added revertReason * added test file for trace_transaction with revertReason Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Updated netty (#3538) * updated netty Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * check types before providing a PowMiningCoordinator (#3548) Signed-off-by: Justin Florentine <justin+github@florentine.us> * add kiln network, add network option for fast-sync capable (#3547) * add kiln network, add network option for fast-sync capable Signed-off-by: garyschulte <garyschulte@gmail.com> * Richer return information for Precompiled Contracts (#3546) Allow precompiled contracts to return richer information instead of results/fail. System/precompile contracts can now revert, fail, refund gas, etc. instead of just succeed or fail. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> * Refactor graphqlcontext since getContext() is deprecated (#3536) * refactor graphqlcontext since getContext() is deprecated Signed-off-by: Sandra Wang <yx97.wang@gmail.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Always show privacyGroupId on PrivateTransactionReceipt (#3544) - This is to provide a clearer way of knowing which privacyGroupId a private transaction ended up in. Signed-off-by: Antony Denyer <git@antonydenyer.co.uk> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Acceptance test for execution engine apis (#3533) * added acceptance test for execution engine apis * removed check of payload id length Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> * fix: AuthProvider deprecated, refactor TomlAuth with AuthenticationProvider (#3550) Signed-off-by: Sandra Wang <yx97.wang@gmail.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> * modified batch request test to avoid async complete issue (#3556) Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Frank Li <b439988l@gmail.com> * Stratum mining errata (#3554) * couple bits of additional plumbing to ensure transitionCoordinator correctly routes stratum ethash observers Signed-off-by: garyschulte <garyschulte@gmail.com> * ignore flaky test (#3566) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * remove requirement for CL to have zero blocknumber for TransitionConfiguration (#3565) Signed-off-by: garyschulte <garyschulte@gmail.com> * added trace logging of parameter RPC calls (#3553) * added trace logging of parameter RPC calls Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Revert "upgrade vertx (#3530)" (#3567) This reverts commit 9d2d87e. Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * added extra info to issue template (#3551) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Added debug logging to header download step. (#3568) Signed-off-by: Mark Terry <mark.terry@consensys.net> Signed-off-by: Frank Li <b439988l@gmail.com> * [#2766]fix: clean up deprecation warnings (#3511) * clean up deprecation warnings *Quantity Interface getValue() * LegacyPrivateStateStorage * GraphQLDataFetcherContext Signed-off-by: Sandra Wang <yx97.wang@gmail.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> * updated TTD for Kiln (#3573) Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * add execution engine endpoints to docker ports (#3575) * add execution engine endpoints to docker ports Signed-off-by: garyschulte <garyschulte@gmail.com> * Warn if consensus client doesn't call transition configuration endpoint within 120 seconds (#3569) * add qos timer to engine_exchangeTransitionConfiguration Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> * updated tests to ensure hex values are returned (#3564) Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> * [MINOR] corrections to changelog and typos (#3580) * typos * 3379 was the pr to merge branch * added link for 3202 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * [MINOR] xl executor for quorum ATs (nightly) (#3571) * xl executor Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * WebSocket batch test - remove Ignore (#3579) * remove ignore of batch websocket test Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * Added --version flag to subcommands [#2762] (#3577) * added --version flag to subcommands (#2762) Signed-off-by: Davide Savazzi <davide@davidesavazzi.net> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> Signed-off-by: Frank Li <b439988l@gmail.com> * Add headings to Besu help (#3559) * Headings are bold and cyan * grouping graphQL related options * Json RPC Http Option Group Json RPC Websocket Option Group Signed-off-by: Sandra Wang <yx97.wang@gmail.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> * update picocli (#3552) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * change gradle version Signed-off-by: Frank Li <b439988l@gmail.com> Co-authored-by: Danno Ferrin <danno.ferrin@gmail.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Antony Denyer <git@antonydenyer.co.uk> Co-authored-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Adrian Sutton <adrian.sutton@consensys.net> Co-authored-by: Jiri Peinlich <jiri.peinlich@gmail.com> Co-authored-by: mark-terry <36909937+mark-terry@users.noreply.github.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: MadelineMurray <43356962+MadelineMurray@users.noreply.github.com> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: mbaxter <meredith.baxter@palm.io> Co-authored-by: Sandra Wang <yx97.wang@gmail.com> Co-authored-by: Davide Savazzi <davide.savazzi@gmail.com>

* Json RPC endpoint and test files for trace_rawTransaction * cache the block number to make sure we are using the same block Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Co-authored-by: Frank Li <b439988l@gmail.com> Co-authored-by: MadelineMurray <43356962+MadelineMurray@users.noreply.github.com>

macfarla added 2 commits February 18, 2022 14:09

test files from parity

dc14214

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

some WIP code for trace_rawTransaction

178b024

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

macfarla marked this pull request as draft February 18, 2022 05:08

macfarla changed the title ~~Trace raw transaction~~ WIP trace_rawTransaction Feb 18, 2022

macfarla added 9 commits February 21, 2022 09:55

Merge branch 'main' of github.com:hyperledger/besu into trace-raw-tra…

f81868a

…nsaction

added test dirs to specs; handle empty optionals

ae62142

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

handle null

20f0949

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

headers

4b66fa1

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Merge branch 'main' of github.com:hyperledger/besu into trace-raw-tra…

9000863

…nsaction

cleanup

8cebba7

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

payload

692aa82

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

comment

9293b36

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

error response

5ab6ba6

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

macfarla changed the title ~~WIP trace_rawTransaction~~ trace_rawTransaction Feb 21, 2022

macfarla marked this pull request as ready for review February 21, 2022 04:47

Merge branch 'main' of github.com:hyperledger/besu into trace-raw-tra…

d326deb

…nsaction

frankisawesome reviewed Feb 22, 2022

View reviewed changes

macfarla added 3 commits February 24, 2022 16:17

Merge branch 'main' of github.com:hyperledger/besu into trace-raw-tra…

159c311

…nsaction

PR review

4355d5e

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

changelog

7b8dbd5

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

frankisawesome mentioned this pull request Mar 2, 2022

Refactor trace api methods #3510

Merged

1 task

merge main changes

a0bf437

Signed-off-by: Frank Li <b439988l@gmail.com>

matkt previously requested changes Mar 3, 2022

View reviewed changes

...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/TraceRawTransaction.java Outdated Show resolved Hide resolved

macfarla added 2 commits March 4, 2022 10:36

merge main

1ee657f

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Merge branch 'main' of github.com:hyperledger/besu into trace-raw-tra…

9b46f20

…nsaction

macfarla added 4 commits March 4, 2022 10:53

Merge branch 'trace-raw-transaction' of github.com:macfarla/besu into…

a3ddbad

… trace-raw-transaction

comment

5857359

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

code smells

9897f8f

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

merge

df642e8

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

macfarla and others added 3 commits March 4, 2022 14:03

code smells

c56c5d8

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

changelog

cc7a10b

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Merge branch 'main' into trace-raw-transaction

341c18d

pinges reviewed Mar 7, 2022

View reviewed changes

Merge branch 'main' of github.com:hyperledger/besu into trace-raw-tra…

7d227ab

…nsaction

macfarla mentioned this pull request Mar 7, 2022

Trace RPC methods - consistent approach to logging #3528

Closed

macfarla added 4 commits March 7, 2022 13:40

cache the block number to make sure we are using the same block

4bb3920

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Merge branch 'trace-raw-transaction' of github.com:macfarla/besu into…

f19c781

… trace-raw-transaction

check optional

eb45609

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

Merge branch 'main' of github.com:hyperledger/besu into trace-raw-tra…

dd5877f

…nsaction

pinges approved these changes Mar 7, 2022

View reviewed changes

Merge branch 'main' into trace-raw-transaction

4f58529

macfarla enabled auto-merge (squash) March 7, 2022 05:18

macfarla merged commit 26be16c into hyperledger:main Mar 7, 2022

macfarla deleted the trace-raw-transaction branch March 9, 2022 02:38

macfarla added the mainnet label Jun 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

trace_rawTransaction #3459

trace_rawTransaction #3459

macfarla commented Feb 18, 2022 •

edited

Loading

frankisawesome left a comment

pinges Mar 7, 2022

macfarla Mar 7, 2022

pinges Mar 7, 2022

macfarla Mar 7, 2022

pinges left a comment

sonarqubecloud bot commented Mar 7, 2022

trace_rawTransaction #3459

trace_rawTransaction #3459

Conversation

macfarla commented Feb 18, 2022 • edited Loading

Changelog

frankisawesome left a comment

Choose a reason for hiding this comment

pinges Mar 7, 2022

Choose a reason for hiding this comment

macfarla Mar 7, 2022

Choose a reason for hiding this comment

pinges Mar 7, 2022

Choose a reason for hiding this comment

macfarla Mar 7, 2022

Choose a reason for hiding this comment

pinges left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 7, 2022

macfarla commented Feb 18, 2022 •

edited

Loading