Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emeritus guideline change: 2 reporting quarters of inactivity #3233

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Emeritus guideline change: 2 reporting quarters of inactivity #3233

merged 3 commits into from
Jan 19, 2022

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Jan 4, 2022 •
edited
Loading

I propose the following changes to the guidelines on moving maintainers to emeritus status:

  • Changed from 1 to 2 quarters of inactivity
  • Also removed link to countdown timer as it's unnecessary. github does a good enough job

This PR will remain open for 2 weeks from today, unless an absolute majority of current maintainers is achieved before then.

Changelog

@macfarla
2 reporting quarters
dff79d5 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into emeritus-guid…
32b4ebd 
…eline
atoulme
atoulme approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

usmansaleem
usmansaleem approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@macfarla macfarla enabled auto-merge (squash) January 19, 2022 03:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@macfarla macfarla merged commit eb7b255 into hyperledger:main Jan 19, 2022
@macfarla macfarla deleted the emeritus-guideline branch January 23, 2022 21:30
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
2 reporting quarters (hyperledger#3233)
0d0a7f9 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taccatisid taccatisid taccatisid approved these changes

@frankisawesome frankisawesome frankisawesome approved these changes

@matkt matkt matkt approved these changes

@daniellehrner daniellehrner daniellehrner approved these changes

@siladu siladu siladu approved these changes

@lucassaldanha lucassaldanha lucassaldanha approved these changes

@garyschulte garyschulte garyschulte approved these changes

@jframe jframe jframe approved these changes

@usmansaleem usmansaleem usmansaleem approved these changes

@diega diega diega approved these changes

@ajsutton ajsutton ajsutton approved these changes

@atoulme atoulme atoulme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.