Validate that blockperiodseconds is set to a positive integer #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
…lues Signed-off-by: George Patterson <g-patt@outlook.com>
…nds property Signed-off-by: George Patterson <g-patt@outlook.com>
…kperiodseconds Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
georgep9
force-pushed
the
validate_blockperiodseconds
branch
from
4646893 to
5b3e5fc
Compare
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
…kperiodseconds Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
…kperiodseconds Signed-off-by: George Patterson <g-patt@outlook.com>
config/src/test/java/org/hyperledger/besu/config/JsonBftConfigOptionsTest.java
Show resolved
Hide resolved
Signed-off-by: George Patterson <g-patt@outlook.com>
siladu
reviewed
Dec 21, 2021
besu/src/main/java/org/hyperledger/besu/cli/subcommands/operator/GenerateBlockchainConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
siladu
reviewed
Dec 21, 2021
config/src/test/java/org/hyperledger/besu/config/CliqueConfigOptionsTest.java
Outdated
Show resolved
Hide resolved
…in JsonUtil Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
…kperiodseconds Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
…kperiodseconds Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
siladu
requested changes
Dec 22, 2021
There was a problem hiding this comment.
Minor nitpicks and suggestions in the comments.
I am going to be annoying though and ask that you make the same change for BftFork.getBlockPeriodSeconds please :)
It is possible to use a 'transition' to change the blockperiodseconds of an existing network so it needs the same validation constraints applied to it.
See: https://besu.hyperledger.org/en/stable/HowTo/Configure/Consensus-Protocols/IBFT/#configure-block-time-on-an-existing-network-deployment
Note this transition also applies to QBFT
util/src/test/java/org/hyperledger/besu/util/number/PositiveNumberTest.java
Outdated
Show resolved
Hide resolved
config/src/test/java/org/hyperledger/besu/config/JsonBftConfigOptionsTest.java
Outdated
Show resolved
Hide resolved
config/src/test/java/org/hyperledger/besu/config/CliqueConfigOptionsTest.java
Outdated
Show resolved
Hide resolved
util/src/test/java/org/hyperledger/besu/util/number/PositiveNumberTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
siladu
requested changes
Dec 22, 2021
…ts. Changes applied for BftFork. Signed-off-by: George Patterson <g-patt@outlook.com>
siladu
reviewed
Dec 22, 2021
…kperiodseconds Signed-off-by: George Patterson <g-patt@outlook.com>
…kperiodseconds Signed-off-by: George Patterson <g-patt@outlook.com>
Signed-off-by: George Patterson <g-patt@outlook.com>
|
Kudos, SonarCloud Quality Gate passed! |
matkt
pushed a commit
to matkt/besu
that referenced
this pull request
Jan 5, 2022
…edger#3186) Implemented getPositiveInt function in JsonUtil to validate a JSON positive number value. Using this function, the blockperiodseconds should now be validated whenever retrieved from the genesis config, including transitions. Signed-off-by: George Patterson <g-patt@outlook.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…edger#3186) Implemented getPositiveInt function in JsonUtil to validate a JSON positive number value. Using this function, the blockperiodseconds should now be validated whenever retrieved from the genesis config, including transitions. Signed-off-by: George Patterson <g-patt@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Implemented getPositiveInt function in JsonUtil to validate a JSON positive number value. Using this function, the blockperiodseconds should now be validated whenever retrieved from the genensis config.
Fixed Issue(s)
Fixes #3093