Removing deprecated hash variable which was used to cache the transaction

[mohitsaxenaknoldus]

PR description

Fixed Issue(s)

#2937

Changelog

• I thought about the changelog and included a changelog update if required.

[macfarla]

Looks ok to me @mohitsaxenaknoldus
However the unit test step is failing because the plugin API hash needs updating as a result of this change:

* What went wrong:
Execution failed for task ':plugin-api:checkAPIChanges'.
> For the Plugin APIs the checksum of the project did not match what was expected.
  
  If this is a deliberate change where you have thought through backwards compatibility,
  then update "Expected" for "Calculated" in the appropriate build.gradle as the knownHash for this task.
  Expected   : /M23BAhwqtMpjhcoHDMJvbHyhJ4z39z2jJMWUGOBO14=
  Calculated : iVl4LwulrgbVqYsahA4YvgrMqc22OxBk43hFsoYPA5w=

[mohitsaxenaknoldus]

Looks ok to me @mohitsaxenaknoldus However the unit test step is failing because the plugin API hash needs updating as a result of this change:

* What went wrong:
Execution failed for task ':plugin-api:checkAPIChanges'.
> For the Plugin APIs the checksum of the project did not match what was expected.
  
  If this is a deliberate change where you have thought through backwards compatibility,
  then update "Expected" for "Calculated" in the appropriate build.gradle as the knownHash for this task.
  Expected   : /M23BAhwqtMpjhcoHDMJvbHyhJ4z39z2jJMWUGOBO14=
  Calculated : iVl4LwulrgbVqYsahA4YvgrMqc22OxBk43hFsoYPA5w=

Oh ok. How can I fix that?

[macfarla]

Looks ok to me @mohitsaxenaknoldus However the unit test step is failing because the plugin API hash needs updating as a result of this change:

* What went wrong:
Execution failed for task ':plugin-api:checkAPIChanges'.
> For the Plugin APIs the checksum of the project did not match what was expected.
  
  If this is a deliberate change where you have thought through backwards compatibility,
  then update "Expected" for "Calculated" in the appropriate build.gradle as the knownHash for this task.
  Expected   : /M23BAhwqtMpjhcoHDMJvbHyhJ4z39z2jJMWUGOBO14=
  Calculated : iVl4LwulrgbVqYsahA4YvgrMqc22OxBk43hFsoYPA5w=

Oh ok. How can I fix that?
You have to do exactly what it says in the message above - update the knownHash in plugin-api/build.gradle

[mohitsaxenaknoldus]

@macfarla Fixed the chandelog, please check now. Sorry for the delays!

[macfarla]

@mohitsaxenaknoldus the changelog entry for this should be moved under the topmost release in the changelog ie 22.1.0-RC2
Also the hash needs updating in
Build file '/home/circleci/project/plugin-api/build.gradle' line: 53

If this is a deliberate change where you have thought through backwards compatibility,
then update "Expected" for "Calculated" in the appropriate build.gradle as the knownHash for this task.
Expected : DhISJBKoARZyoiT387UIA7QfcEwyOcIYm17f/fLsJRM=
Calculated : pDLQUs2Gl9hFV1ecKSacbbfwovrjMf/IBPiY1zkOZlI=

[mohitsaxenaknoldus]

@mohitsaxenaknoldus the changelog entry for this should be moved under the topmost release in the changelog ie 22.1.0-RC2 Also the hash needs updating in Build file '/home/circleci/project/plugin-api/build.gradle' line: 53

If this is a deliberate change where you have thought through backwards compatibility, then update "Expected" for "Calculated" in the appropriate build.gradle as the knownHash for this task. Expected : DhISJBKoARZyoiT387UIA7QfcEwyOcIYm17f/fLsJRM= Calculated : pDLQUs2Gl9hFV1ecKSacbbfwovrjMf/IBPiY1zkOZlI=

Done.
Also, here it is showing DCO ok but on CI DCO is failing, why?

[macfarla]

Also, here it is showing DCO ok but on CI DCO is failing, why?
There's a DCO issue on another branch. We are working on it, should be fixed shortly.

[mohitsaxenaknoldus]

Also, here it is showing DCO ok but on CI DCO is failing, why?
There's a DCO issue on another branch. We are working on it, should be fixed shortly.

Oh ok, seems to be passing now.

[mohitsaxenaknoldus]

Let's see if it works now @macfarla

[mohitsaxenaknoldus]

Hey, @macfarla Is this good to merge now?

plugin-api hash has now been updated correctly

[macfarla]

Somehow the hash got overwritten again in a "merge from main" commit. Fingers crossed I've fixed it now! Thanks for your patience with this one @mohitsaxenaknoldus !

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[macfarla]

Thanks again for your patience with getting this change merged in @mohitsaxenaknoldus - hopefully your next contribution doesn't hit so many bumps in the road!!