Tidy up TODOs (move them to PR discussion)

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/BftBlockInterface.java

@@ -66,8 +66,7 @@ public Optional<ValidatorVote> extractVoteFromHeader(final BlockHeader header) {
 
   @Override
   public Collection<Address> validatorsInBlock(final BlockHeader header) {
-    final BftExtraData bftExtraData =
-        bftExtraDataCodec.decode(header); // TODO SLD fails when starting with ibft 1
+    final BftExtraData bftExtraData = bftExtraDataCodec.decode(header);
     return bftExtraData.getValidators();
   }
 

consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/BftForksSchedule.java

@@ -31,7 +31,6 @@
 
 import com.google.common.annotations.VisibleForTesting;
 
-// TODO SLD if using this with <MiningCoordinator>, should I rename this to ForksSchedule?
 public class BftForksSchedule<C> {
 
   private final NavigableSet<ForkSpec<C>> forks =

consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/blockcreation/BftMiningCoordinator.java

@@ -79,7 +79,7 @@ public BftMiningCoordinator(
   public void start() {
     if (state.compareAndSet(State.IDLE, State.RUNNING)) {
       bftExecutors.start();
-      blockAddedObserverId = blockchain.observeBlockAdded(this); // TODO SLD duplicate block event
+      blockAddedObserverId = blockchain.observeBlockAdded(this);
       eventHandler.start();
       bftExecutors.executeBftProcessor(bftProcessor);
     }

consensus/common/src/main/java/org/hyperledger/besu/consensus/common/bft/blockcreation/SchedulableMiningCoordinator.java

@@ -119,10 +119,10 @@ public void onBlockAdded(final BlockAddedEvent event) {
         miningCoordinatorSchedule.getFork(currentBlock + 1).getValue();
     if (activeMiningCoordinator != nextMiningCoordinator) {
       LOG.debug(
-          "Switching mining coordinator after block {} from {} to {}",
+          "Switching mining coordinator at block {} from {} to {}",
           currentBlock,
-          activeMiningCoordinator.getClass().getName(),
-          nextMiningCoordinator.getClass().getTypeName());
+          activeMiningCoordinator.getClass().getSimpleName(),
+          nextMiningCoordinator.getClass().getSimpleName());
       activeMiningCoordinator.stop();
       nextMiningCoordinator.start();
       activeMiningCoordinator = nextMiningCoordinator;

util/src/main/java/org/hyperledger/besu/util/Subscribers.java

@@ -37,7 +37,7 @@
  * subscribers.unsubscribe(this::onSomeEvent);</code>
  * </pre>
  *
- * <p>Since the two separate <code>this:onSomeEvent</code> are not equal, the subscriber wouldn't be
+ * <p>Since the two separate <code>this::onSomeEvent</code> are not equal, the subscriber wouldn't be
  * removed. This bug is avoided by assigning each subscriber a unique ID and using that to
  * unsubscribe.
  *