(internal) Refactor 'onchain' to 'flexible' where applicable #3075

frankisawesome · 2021-11-17T06:14:50Z

Signed-off-by: Frank Li b439988l@gmail.com

PR description

This PR changes the following:

Refactors the term 'onchain' in the privacy group context to 'flexible'
Deprecating the CLI option '--privacy-onchain-groups-enabled' in favour of '--privacy-flexible-groups-enabled'
Tests around the CLI options (using old -> warning, using both -> crash with an excpetion)

Notes for reviewers

This is a large refactoring PR, you should only review on the logic changes in

BesuCommand
BesuCommandTest
CommandLineUtils
ConfigOptionSearchAndRunHandler

All other changes are in variable names only and can be skimmed through.

I'm not so sure about the changes in solidity files, I assume they are fine.

Fixed Issue(s)

Fixes #2960

Changelog

I thought about the changelog and included a changelog update if required.

Signed-off-by: Frank Li <b439988l@gmail.com>

.../dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/node/ProcessBesuNodeRunner.java

Signed-off-by: Frank Li <b439988l@gmail.com>

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

Signed-off-by: Frank Li <b439988l@gmail.com>

merge main

merge main upstream

Signed-off-by: Frank Li <b439988l@gmail.com>

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java

besu/src/main/java/org/hyperledger/besu/cli/util/ConfigOptionSearchAndRunHandler.java

privacy-contracts/src/main/solidity/DefaultFlexiblePrivacyGroupManagementContract.sol

Signed-off-by: Frank Li <b439988l@gmail.com>

macfarla

Looks good overall, couple of things to change:

there's a few spots related to permissioning rather than privacy where we want to revert back to "onchain"
the RPC method name change - we will need to support both names for at least one major release

...s/acceptance/dsl/privacy/contract/CallFlexiblePermissioningPrivateSmartContractFunction.java

...dger/besu/tests/acceptance/permissioning/NodeSmartContractPermissioningV2AcceptanceTest.java

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java

besu/src/test/resources/everything_config.toml

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/RpcMethod.java

.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/response/JsonRpcError.java

...perledger/besu/ethereum/permissioning/account/AccountPermissioningControllerFactoryTest.java

...org/hyperledger/besu/ethereum/permissioning/node/NodePermissioningControllerFactoryTest.java

privacy-contracts/src/main/solidity/DefaultFlexiblePrivacyGroupManagementContract.sol

macfarla · 2021-11-23T03:25:02Z

Besu breaking change policy https://github.com/hyperledger/besu/blob/main/CHANGELOG.md#2110-breaking-changes

Signed-off-by: Frank Li <b439988l@gmail.com>

...r/besu/ethereum/api/jsonrpc/internal/privacy/methods/privx/PrivxFindOnchainPrivacyGroup.java

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/response/JsonRpcError.java

...g/hyperledger/besu/ethereum/permissioning/account/AccountPermissioningControllerFactory.java

evm/src/main/java/org/hyperledger/besu/evm/processor/MessageCallProcessor.java

Signed-off-by: Frank Li <b439988l@gmail.com>

…ub.com:frankisawesome/besu into internal/flexible-privacy-group-naming-cleanup merge master

macfarla

LGTM

sonarqubecloud · 2021-11-25T06:07:15Z

SonarCloud Quality Gate failed.

3 Bugs
0 Vulnerabilities
0 Security Hotspots
117 Code Smells

50.0% Coverage
2.2% Duplication

…dger#3075) * CLI option name change Signed-off-by: Frank Li <b439988l@gmail.com> * refactor privacyparameters.java and add deprecation warning Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring Signed-off-by: Frank Li <b439988l@gmail.com> * add to everything.toml Signed-off-by: Frank Li <b439988l@gmail.com> * bugs Signed-off-by: Frank Li <b439988l@gmail.com> * more missing variable names Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * fix compile error Signed-off-by: Frank Li <b439988l@gmail.com> * add new test to invalidate passing both commands Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring + more tests Signed-off-by: Frank Li <b439988l@gmail.com> * new batch Signed-off-by: Frank Li <b439988l@gmail.com> * final batch? Signed-off-by: Frank Li <b439988l@gmail.com> * failing unit test Signed-off-by: Frank Li <b439988l@gmail.com> * revert incorrect refactoring back to onchain Signed-off-by: Frank Li <b439988l@gmail.com> * fix unit test Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * support both privx methods Signed-off-by: Frank Li <b439988l@gmail.com> * add to changelog Signed-off-by: Frank Li <b439988l@gmail.com> * address comment Signed-off-by: Frank Li <b439988l@gmail.com> * add plugin privacy Signed-off-by: Frank Li <b439988l@gmail.com>

…dger#3075) * CLI option name change Signed-off-by: Frank Li <b439988l@gmail.com> * refactor privacyparameters.java and add deprecation warning Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring Signed-off-by: Frank Li <b439988l@gmail.com> * add to everything.toml Signed-off-by: Frank Li <b439988l@gmail.com> * bugs Signed-off-by: Frank Li <b439988l@gmail.com> * more missing variable names Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * fix compile error Signed-off-by: Frank Li <b439988l@gmail.com> * add new test to invalidate passing both commands Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring + more tests Signed-off-by: Frank Li <b439988l@gmail.com> * new batch Signed-off-by: Frank Li <b439988l@gmail.com> * final batch? Signed-off-by: Frank Li <b439988l@gmail.com> * failing unit test Signed-off-by: Frank Li <b439988l@gmail.com> * revert incorrect refactoring back to onchain Signed-off-by: Frank Li <b439988l@gmail.com> * fix unit test Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * support both privx methods Signed-off-by: Frank Li <b439988l@gmail.com> * add to changelog Signed-off-by: Frank Li <b439988l@gmail.com> * address comment Signed-off-by: Frank Li <b439988l@gmail.com> * add plugin privacy Signed-off-by: Frank Li <b439988l@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>

* compile issues sorted, some tests failing Signed-off-by: Justin Florentine <justin+github@florentine.us> * closing runnerBehind closes the vertx shared with runnerAhead, which now throws an exception Signed-off-by: Justin Florentine <justin+github@florentine.us> * checkpoint when 4/5 websocket login tests pass Signed-off-by: Justin Florentine <justin+github@florentine.us> * exp moved to attribute from principal Signed-off-by: Justin Florentine <justin+github@florentine.us> * fixed more tests Signed-off-by: Justin Florentine <justin+github@florentine.us> * fixed more tests Signed-off-by: Justin Florentine <justin+github@florentine.us> * exception handling test improvement Signed-off-by: Justin Florentine <justin+github@florentine.us> * exception handling test improvement Signed-off-by: Justin Florentine <justin+github@florentine.us> * static renamed Signed-off-by: Justin Florentine <justin+github@florentine.us> * We want old implementation of the host() Newly vertex handles the forward headers and modifies host(). In the process vert.x loses track of port from Host header in case the port was not a string. Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * adding dependency on jackson-databind for tests Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * making sure changes are spotless Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * Dealing with regression Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * fixing last failing vert.x test hopefully Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * removed commented out code Signed-off-by: Justin Florentine <justin+github@florentine.us> * reverts debugging adjustment Signed-off-by: Justin Florentine <justin+github@florentine.us> * removed commented out code Signed-off-by: Justin Florentine <justin+github@florentine.us> * minor whitespace cleanup Signed-off-by: Justin Florentine <justin+github@florentine.us> * (internal) Refactor 'onchain' to 'flexible' where applicable (#3075) * CLI option name change Signed-off-by: Frank Li <b439988l@gmail.com> * refactor privacyparameters.java and add deprecation warning Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring Signed-off-by: Frank Li <b439988l@gmail.com> * add to everything.toml Signed-off-by: Frank Li <b439988l@gmail.com> * bugs Signed-off-by: Frank Li <b439988l@gmail.com> * more missing variable names Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * fix compile error Signed-off-by: Frank Li <b439988l@gmail.com> * add new test to invalidate passing both commands Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring + more tests Signed-off-by: Frank Li <b439988l@gmail.com> * new batch Signed-off-by: Frank Li <b439988l@gmail.com> * final batch? Signed-off-by: Frank Li <b439988l@gmail.com> * failing unit test Signed-off-by: Frank Li <b439988l@gmail.com> * revert incorrect refactoring back to onchain Signed-off-by: Frank Li <b439988l@gmail.com> * fix unit test Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * support both privx methods Signed-off-by: Frank Li <b439988l@gmail.com> * add to changelog Signed-off-by: Frank Li <b439988l@gmail.com> * address comment Signed-off-by: Frank Li <b439988l@gmail.com> * add plugin privacy Signed-off-by: Frank Li <b439988l@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us> * checkpoint when 4/5 websocket login tests pass Signed-off-by: Justin Florentine <justin+github@florentine.us> * trying to figure out how to decouple this test Signed-off-by: Justin Florentine <justin+github@florentine.us> * spotless Signed-off-by: Justin Florentine <justin+github@florentine.us> * removes Orion from integration test Signed-off-by: Justin Florentine <justin+github@florentine.us> * spotless Signed-off-by: Justin Florentine <justin+github@florentine.us> * Add jackson dependency to merge module Signed-off-by: Diego López León <dieguitoll@gmail.com> * Migrate JWTAuthOptions creations for public keys Signed-off-by: Diego López León <dieguitoll@gmail.com> * Check http client response status Signed-off-by: Diego López León <dieguitoll@gmail.com> * Replace Orian with Tessera in tests Signed-off-by: Diego López León <dieguitoll@gmail.com> * Change Tessera expected error messages in tests Signed-off-by: Diego López León <dieguitoll@gmail.com> * Change executor of integrationTests to allow spanning Docker processes Signed-off-by: Diego López León <dieguitoll@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Jiri Peinlich <jiri.peinlich@gmail.com> Co-authored-by: Frank Li <39414003+frankisawesome@users.noreply.github.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* compile issues sorted, some tests failing Signed-off-by: Justin Florentine <justin+github@florentine.us> * closing runnerBehind closes the vertx shared with runnerAhead, which now throws an exception Signed-off-by: Justin Florentine <justin+github@florentine.us> * checkpoint when 4/5 websocket login tests pass Signed-off-by: Justin Florentine <justin+github@florentine.us> * exp moved to attribute from principal Signed-off-by: Justin Florentine <justin+github@florentine.us> * fixed more tests Signed-off-by: Justin Florentine <justin+github@florentine.us> * fixed more tests Signed-off-by: Justin Florentine <justin+github@florentine.us> * exception handling test improvement Signed-off-by: Justin Florentine <justin+github@florentine.us> * exception handling test improvement Signed-off-by: Justin Florentine <justin+github@florentine.us> * static renamed Signed-off-by: Justin Florentine <justin+github@florentine.us> * We want old implementation of the host() Newly vertex handles the forward headers and modifies host(). In the process vert.x loses track of port from Host header in case the port was not a string. Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * adding dependency on jackson-databind for tests Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * making sure changes are spotless Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * Dealing with regression Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * fixing last failing vert.x test hopefully Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * removed commented out code Signed-off-by: Justin Florentine <justin+github@florentine.us> * reverts debugging adjustment Signed-off-by: Justin Florentine <justin+github@florentine.us> * removed commented out code Signed-off-by: Justin Florentine <justin+github@florentine.us> * minor whitespace cleanup Signed-off-by: Justin Florentine <justin+github@florentine.us> * (internal) Refactor 'onchain' to 'flexible' where applicable (hyperledger#3075) * CLI option name change Signed-off-by: Frank Li <b439988l@gmail.com> * refactor privacyparameters.java and add deprecation warning Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring Signed-off-by: Frank Li <b439988l@gmail.com> * add to everything.toml Signed-off-by: Frank Li <b439988l@gmail.com> * bugs Signed-off-by: Frank Li <b439988l@gmail.com> * more missing variable names Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * fix compile error Signed-off-by: Frank Li <b439988l@gmail.com> * add new test to invalidate passing both commands Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring + more tests Signed-off-by: Frank Li <b439988l@gmail.com> * new batch Signed-off-by: Frank Li <b439988l@gmail.com> * final batch? Signed-off-by: Frank Li <b439988l@gmail.com> * failing unit test Signed-off-by: Frank Li <b439988l@gmail.com> * revert incorrect refactoring back to onchain Signed-off-by: Frank Li <b439988l@gmail.com> * fix unit test Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * support both privx methods Signed-off-by: Frank Li <b439988l@gmail.com> * add to changelog Signed-off-by: Frank Li <b439988l@gmail.com> * address comment Signed-off-by: Frank Li <b439988l@gmail.com> * add plugin privacy Signed-off-by: Frank Li <b439988l@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us> * checkpoint when 4/5 websocket login tests pass Signed-off-by: Justin Florentine <justin+github@florentine.us> * trying to figure out how to decouple this test Signed-off-by: Justin Florentine <justin+github@florentine.us> * spotless Signed-off-by: Justin Florentine <justin+github@florentine.us> * removes Orion from integration test Signed-off-by: Justin Florentine <justin+github@florentine.us> * spotless Signed-off-by: Justin Florentine <justin+github@florentine.us> * Add jackson dependency to merge module Signed-off-by: Diego López León <dieguitoll@gmail.com> * Migrate JWTAuthOptions creations for public keys Signed-off-by: Diego López León <dieguitoll@gmail.com> * Check http client response status Signed-off-by: Diego López León <dieguitoll@gmail.com> * Replace Orian with Tessera in tests Signed-off-by: Diego López León <dieguitoll@gmail.com> * Change Tessera expected error messages in tests Signed-off-by: Diego López León <dieguitoll@gmail.com> * Change executor of integrationTests to allow spanning Docker processes Signed-off-by: Diego López León <dieguitoll@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Jiri Peinlich <jiri.peinlich@gmail.com> Co-authored-by: Frank Li <39414003+frankisawesome@users.noreply.github.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>

…dger#3075) * CLI option name change Signed-off-by: Frank Li <b439988l@gmail.com> * refactor privacyparameters.java and add deprecation warning Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring Signed-off-by: Frank Li <b439988l@gmail.com> * add to everything.toml Signed-off-by: Frank Li <b439988l@gmail.com> * bugs Signed-off-by: Frank Li <b439988l@gmail.com> * more missing variable names Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * fix compile error Signed-off-by: Frank Li <b439988l@gmail.com> * add new test to invalidate passing both commands Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring + more tests Signed-off-by: Frank Li <b439988l@gmail.com> * new batch Signed-off-by: Frank Li <b439988l@gmail.com> * final batch? Signed-off-by: Frank Li <b439988l@gmail.com> * failing unit test Signed-off-by: Frank Li <b439988l@gmail.com> * revert incorrect refactoring back to onchain Signed-off-by: Frank Li <b439988l@gmail.com> * fix unit test Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * support both privx methods Signed-off-by: Frank Li <b439988l@gmail.com> * add to changelog Signed-off-by: Frank Li <b439988l@gmail.com> * address comment Signed-off-by: Frank Li <b439988l@gmail.com> * add plugin privacy Signed-off-by: Frank Li <b439988l@gmail.com>

* compile issues sorted, some tests failing Signed-off-by: Justin Florentine <justin+github@florentine.us> * closing runnerBehind closes the vertx shared with runnerAhead, which now throws an exception Signed-off-by: Justin Florentine <justin+github@florentine.us> * checkpoint when 4/5 websocket login tests pass Signed-off-by: Justin Florentine <justin+github@florentine.us> * exp moved to attribute from principal Signed-off-by: Justin Florentine <justin+github@florentine.us> * fixed more tests Signed-off-by: Justin Florentine <justin+github@florentine.us> * fixed more tests Signed-off-by: Justin Florentine <justin+github@florentine.us> * exception handling test improvement Signed-off-by: Justin Florentine <justin+github@florentine.us> * exception handling test improvement Signed-off-by: Justin Florentine <justin+github@florentine.us> * static renamed Signed-off-by: Justin Florentine <justin+github@florentine.us> * We want old implementation of the host() Newly vertex handles the forward headers and modifies host(). In the process vert.x loses track of port from Host header in case the port was not a string. Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * adding dependency on jackson-databind for tests Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * making sure changes are spotless Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * Dealing with regression Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * fixing last failing vert.x test hopefully Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> * removed commented out code Signed-off-by: Justin Florentine <justin+github@florentine.us> * reverts debugging adjustment Signed-off-by: Justin Florentine <justin+github@florentine.us> * removed commented out code Signed-off-by: Justin Florentine <justin+github@florentine.us> * minor whitespace cleanup Signed-off-by: Justin Florentine <justin+github@florentine.us> * (internal) Refactor 'onchain' to 'flexible' where applicable (hyperledger#3075) * CLI option name change Signed-off-by: Frank Li <b439988l@gmail.com> * refactor privacyparameters.java and add deprecation warning Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring Signed-off-by: Frank Li <b439988l@gmail.com> * add to everything.toml Signed-off-by: Frank Li <b439988l@gmail.com> * bugs Signed-off-by: Frank Li <b439988l@gmail.com> * more missing variable names Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * more classes Signed-off-by: Frank Li <b439988l@gmail.com> * fix compile error Signed-off-by: Frank Li <b439988l@gmail.com> * add new test to invalidate passing both commands Signed-off-by: Frank Li <b439988l@gmail.com> * more refactoring + more tests Signed-off-by: Frank Li <b439988l@gmail.com> * new batch Signed-off-by: Frank Li <b439988l@gmail.com> * final batch? Signed-off-by: Frank Li <b439988l@gmail.com> * failing unit test Signed-off-by: Frank Li <b439988l@gmail.com> * revert incorrect refactoring back to onchain Signed-off-by: Frank Li <b439988l@gmail.com> * fix unit test Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * comment Signed-off-by: Frank Li <b439988l@gmail.com> * support both privx methods Signed-off-by: Frank Li <b439988l@gmail.com> * add to changelog Signed-off-by: Frank Li <b439988l@gmail.com> * address comment Signed-off-by: Frank Li <b439988l@gmail.com> * add plugin privacy Signed-off-by: Frank Li <b439988l@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us> * checkpoint when 4/5 websocket login tests pass Signed-off-by: Justin Florentine <justin+github@florentine.us> * trying to figure out how to decouple this test Signed-off-by: Justin Florentine <justin+github@florentine.us> * spotless Signed-off-by: Justin Florentine <justin+github@florentine.us> * removes Orion from integration test Signed-off-by: Justin Florentine <justin+github@florentine.us> * spotless Signed-off-by: Justin Florentine <justin+github@florentine.us> * Add jackson dependency to merge module Signed-off-by: Diego López León <dieguitoll@gmail.com> * Migrate JWTAuthOptions creations for public keys Signed-off-by: Diego López León <dieguitoll@gmail.com> * Check http client response status Signed-off-by: Diego López León <dieguitoll@gmail.com> * Replace Orian with Tessera in tests Signed-off-by: Diego López León <dieguitoll@gmail.com> * Change Tessera expected error messages in tests Signed-off-by: Diego López León <dieguitoll@gmail.com> * Change executor of integrationTests to allow spanning Docker processes Signed-off-by: Diego López León <dieguitoll@gmail.com> Co-authored-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Jiri Peinlich <jiri.peinlich@gmail.com> Co-authored-by: Frank Li <39414003+frankisawesome@users.noreply.github.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>

CLI option name change

77629ee

Signed-off-by: Frank Li <b439988l@gmail.com>

frankisawesome marked this pull request as draft November 17, 2021 06:15

macfarla reviewed Nov 18, 2021

View reviewed changes

.../dsl/src/main/java/org/hyperledger/besu/tests/acceptance/dsl/node/ProcessBesuNodeRunner.java Show resolved Hide resolved

frankisawesome added 3 commits November 18, 2021 14:27

refactor privacyparameters.java and add deprecation warning

3357e92

Signed-off-by: Frank Li <b439988l@gmail.com>

more refactoring

12d6778

Signed-off-by: Frank Li <b439988l@gmail.com>

add to everything.toml

ca58f21

Signed-off-by: Frank Li <b439988l@gmail.com>

macfarla reviewed Nov 18, 2021

View reviewed changes

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java Outdated Show resolved Hide resolved

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java Show resolved Hide resolved

frankisawesome added 12 commits November 18, 2021 18:49

merge conflicts

6384585

Signed-off-by: Frank Li <b439988l@gmail.com>

bugs

d619278

Signed-off-by: Frank Li <b439988l@gmail.com>

more missing variable names

a062c9a

Signed-off-by: Frank Li <b439988l@gmail.com>

more classes

63e7ba5

Signed-off-by: Frank Li <b439988l@gmail.com>

more classes

dbb63f1

Signed-off-by: Frank Li <b439988l@gmail.com>

fix compile error

34d76be

Signed-off-by: Frank Li <b439988l@gmail.com>

add new test to invalidate passing both commands

50fc8f4

Signed-off-by: Frank Li <b439988l@gmail.com>

Merge branch 'main' into internal/flexible-privacy-group-naming-cleanup

315c68c

merge main

Merge branch 'main' into internal/flexible-privacy-group-naming-cleanup

1ddfdfb

merge main upstream

more refactoring + more tests

f22d811

Signed-off-by: Frank Li <b439988l@gmail.com>

new batch

841cf8d

Signed-off-by: Frank Li <b439988l@gmail.com>

final batch?

3c33abc

Signed-off-by: Frank Li <b439988l@gmail.com>

frankisawesome marked this pull request as ready for review November 22, 2021 13:58

frankisawesome commented Nov 22, 2021

View reviewed changes

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java Show resolved Hide resolved

frankisawesome commented Nov 22, 2021

View reviewed changes

besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java Show resolved Hide resolved

frankisawesome commented Nov 22, 2021

View reviewed changes

besu/src/main/java/org/hyperledger/besu/cli/util/ConfigOptionSearchAndRunHandler.java Show resolved Hide resolved

frankisawesome commented Nov 22, 2021

View reviewed changes

privacy-contracts/src/main/solidity/DefaultFlexiblePrivacyGroupManagementContract.sol Show resolved Hide resolved

failing unit test

12d916b

Signed-off-by: Frank Li <b439988l@gmail.com>

macfarla requested changes Nov 23, 2021

View reviewed changes

frankisawesome and others added 3 commits November 23, 2021 14:07

Merge branch 'main' into internal/flexible-privacy-group-naming-cleanup

7210ce7

revert incorrect refactoring back to onchain

ee64864

Signed-off-by: Frank Li <b439988l@gmail.com>

fix unit test

59f4f1a

Signed-off-by: Frank Li <b439988l@gmail.com>

frankisawesome and others added 5 commits November 23, 2021 15:41

comment

8963ad8

Signed-off-by: Frank Li <b439988l@gmail.com>

comment

59032dd

Signed-off-by: Frank Li <b439988l@gmail.com>

support both privx methods

e43a8ca

Signed-off-by: Frank Li <b439988l@gmail.com>

add to changelog

6aa9ad4

Signed-off-by: Frank Li <b439988l@gmail.com>

Merge branch 'main' into internal/flexible-privacy-group-naming-cleanup

9415ecf

macfarla reviewed Nov 24, 2021

View reviewed changes

frankisawesome and others added 4 commits November 25, 2021 09:30

address comment

4b9192a

Signed-off-by: Frank Li <b439988l@gmail.com>

Merge branch 'main' into internal/flexible-privacy-group-naming-cleanup

9c36f8b

add plugin privacy

8d6d5f4

Signed-off-by: Frank Li <b439988l@gmail.com>

Merge branch 'internal/flexible-privacy-group-naming-cleanup' of gith…

1836609

…ub.com:frankisawesome/besu into internal/flexible-privacy-group-naming-cleanup merge master

macfarla approved these changes Nov 25, 2021

View reviewed changes

Merge branch 'main' into internal/flexible-privacy-group-naming-cleanup

ab7b54f

macfarla merged commit 183cdaf into hyperledger:main Nov 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(internal) Refactor 'onchain' to 'flexible' where applicable #3075

(internal) Refactor 'onchain' to 'flexible' where applicable #3075

frankisawesome commented Nov 17, 2021 •

edited

Loading

macfarla left a comment

macfarla commented Nov 23, 2021

macfarla left a comment

sonarqubecloud bot commented Nov 25, 2021

(internal) Refactor 'onchain' to 'flexible' where applicable #3075

(internal) Refactor 'onchain' to 'flexible' where applicable #3075

Conversation

frankisawesome commented Nov 17, 2021 • edited Loading

PR description

Notes for reviewers

Fixed Issue(s)

Changelog

macfarla left a comment

Choose a reason for hiding this comment

macfarla commented Nov 23, 2021

macfarla left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 25, 2021

frankisawesome commented Nov 17, 2021 •

edited

Loading