Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve perf trace #3032

Merged
merged 2 commits into from
Nov 15, 2021
Merged

improve perf trace #3032

merged 2 commits into from
Nov 15, 2021

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Nov 10, 2021

Signed-off-by: Karim TAAM karim.t2am@gmail.com

PR description

Optimize the performance of the tracing API by copying the input data only when it is necessary. Tested with some blocks on goerli

Fixed Issue(s)

Changelog

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
@matkt matkt marked this pull request as ready for review November 15, 2021 08:24
Copy link
Contributor

@gezero gezero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@daniellehrner daniellehrner enabled auto-merge (squash) November 15, 2021 08:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@daniellehrner daniellehrner merged commit 270a066 into hyperledger:main Nov 15, 2021
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants