Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bonsai getMutable method regression #2934

Merged
merged 5 commits into from
Oct 28, 2021

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Oct 21, 2021

Signed-off-by: Karim TAAM karim.t2am@gmail.com

PR description

Fixed Issue(s)

Changelog

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matkt matkt force-pushed the fix-bonsai-get-mutable-code branch 2 times, most recently from 33ab518 to 44e36a8 Compare October 22, 2021 12:11
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
@matkt matkt force-pushed the fix-bonsai-get-mutable-code branch from 44e36a8 to a75738a Compare October 25, 2021 09:37
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the fix-bonsai-get-mutable-code branch 2 times, most recently from d2150f3 to da2c1e1 Compare October 27, 2021 14:10
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the fix-bonsai-get-mutable-code branch from da2c1e1 to 49507c6 Compare October 27, 2021 14:13
@garyschulte garyschulte marked this pull request as ready for review October 28, 2021 15:08
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

47.6% 47.6% Coverage
0.0% 0.0% Duplication

@garyschulte garyschulte merged commit ffc8da3 into hyperledger:main Oct 28, 2021
garyschulte pushed a commit that referenced this pull request Oct 28, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
frankisawesome pushed a commit to frankisawesome/besu that referenced this pull request Oct 31, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Frank Li <b439988l@gmail.com>
@matkt matkt deleted the fix-bonsai-get-mutable-code branch March 11, 2022 08:06
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants