-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QBFT support for evmtool #2807
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
jflo
approved these changes
Oct 5, 2021
ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/QBFTGenesisFileModule.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Usman Saleem <usman@usmans.info>
jframe
reviewed
Oct 6, 2021
ProtocolSchedule provideProtocolSchedule( | ||
final GenesisConfigOptions configOptions, | ||
@Named("RevertReasonEnabled") final boolean revertReasonEnabled) { | ||
return QbftProtocolSchedule.create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be able to use the simpler create constructor here, i.e. QbftProtocolSchedule.create(configOptions, bftExtraDataEncoder)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Signed-off-by: Usman Saleem <usman@usmans.info>
jframe
reviewed
Oct 6, 2021
ethereum/evmtool/src/main/java/org/hyperledger/besu/evmtool/QBFTGenesisFileModule.java
Show resolved
Hide resolved
jframe
approved these changes
Oct 6, 2021
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
jframe
added a commit
to jframe/besu
that referenced
this pull request
Oct 12, 2021
commit 75b4a41 Author: Jason Frame <jasonwframe@gmail.com> Date: Tue Oct 12 13:47:01 2021 +1000 add block header test case Signed-off-by: Jason Frame <jasonwframe@gmail.com> commit 7d3001d Author: Jason Frame <jasonwframe@gmail.com> Date: Tue Oct 12 13:31:08 2021 +1000 undo unintentional change fixing unit test Signed-off-by: Jason Frame <jasonwframe@gmail.com> commit 772a428 Author: Jason Frame <jasonwframe@gmail.com> Date: Tue Oct 12 13:21:56 2021 +1000 Qbft validation selection was incorrectly being applied for non validator selection mode transitions Signed-off-by: Jason Frame <jasonwframe@gmail.com> commit a30c314 Author: Antony Denyer <git@antonydenyer.co.uk> Date: Mon Oct 11 09:45:52 2021 +0100 Allow Besu to host RPC endpoints via a plugin. (hyperledger#2754) This is a re-implementation of the initial POC done in PegaSysEng/pantheon#1909 by Danno Ferrin <danno.ferrin@gmail.com> * Only enable plugin rpc api when enabled on --rpc-http-api or --rpc-ws-apis * Only allow new rpc endpoints to be defined Signed-off-by: Antony Denyer <git@antonydenyer.co.uk> commit fc687ab Author: Simon Dudley <simon.dudley@consensys.net> Date: Mon Oct 11 08:18:03 2021 +0100 Qbft RPCs should be disabled after starting with or switching to use validator contract (hyperledger#2817) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> commit 93013e9 Author: Usman Saleem <usman@usmans.info> Date: Fri Oct 8 15:51:40 2021 +1000 Add QBFT support for evmtool (hyperledger#2807) * qbft support in evmtool Signed-off-by: Usman Saleem <usman@usmans.info> commit 215e18c Author: Sally MacFarlane <sally.macfarlane@consensys.net> Date: Fri Oct 8 12:32:52 2021 +1000 master.svg -> main.svg (hyperledger#2864) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> commit 82ecef6 Author: Sally MacFarlane <sally.macfarlane@consensys.net> Date: Fri Oct 8 11:13:11 2021 +1000 Fixed build badge (hyperledger#2863) * typos Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * master -> main Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> commit 5fbf0b1 Author: Sally MacFarlane <sally.macfarlane@consensys.net> Date: Thu Oct 7 19:22:47 2021 +1000 changed to trace level logging (hyperledger#2858) Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> commit fdd9352 Author: Diego López León <dieguitoll@gmail.com> Date: Wed Oct 6 21:51:33 2021 -0300 Add a bash/zsh autocomplete script to distributions (hyperledger#538) (hyperledger#2854) Signed-off-by: Diego López León <dieguitoll@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Oct 14, 2021
* qbft support in evmtool Signed-off-by: Usman Saleem <usman@usmans.info>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Oct 14, 2021
* qbft support in evmtool Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* qbft support in evmtool Signed-off-by: Usman Saleem <usman@usmans.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Support QBFT in evmtool. #2749
Changelog