Split Transaction Gas Calculation from EVM Calculation #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for the EVM library pull out the transaction related gas calculations and move them into their own `TransactionGasCalculator.` This has 4 calls right now, none of which occur inside the EVM: * Intrinsic gas cost * Code Deposit gas cost * Max refund quotient * Max Privacy Marker Transaction intrinsic gas cost. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
atoulme
reviewed
Aug 19, 2021
| * | ||
| * <ul> | ||
| * <li><b>Operation Gas Deductions:</b> Deducting the operation's gas cost from the VM's current | ||
| * message frame because the |
There was a problem hiding this comment.
That incomplete sentence dates back to Pantheon code. But because I touched it I get to fix it ;)
atoulme
reviewed
Aug 19, 2021
| public interface TransactionGasCalculator { | ||
|
|
||
| /** | ||
| * Returns a {@link Transaction}s intrinsic gas cost, i.e. the cost deriving from it's encoded |
| /** | ||
| * Provides various gas cost lookups and calculations used during block processing. | ||
| * | ||
| * <p>The {@code GasCalculator} is meant to encapsulate all {@link Gas}-related calculations except |
There was a problem hiding this comment.
s/GasCalculator/TransactionGasCalculator
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
garyschulte
reviewed
Aug 19, 2021
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/TransactionGasCalculator.java
Outdated
Show resolved
Hide resolved
…nsactionGasCalc Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
|
Thanks Gary. |
1 task
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
) In preparation for the EVM library pull out the transaction related gas calculations and move them into their own `TransactionGasCalculator.` This has 4 calls right now, none of which occur inside the EVM: * Intrinsic gas cost * Code Deposit gas cost * Max refund quotient * Max Privacy Marker Transaction intrinsic gas cost. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the EVM library pull out the transaction related gas
calculations and move them into their own
TransactionGasCalculator.This has 4 calls right now, none of which occur inside the EVM:
Signed-off-by: Danno Ferrin danno.ferrin@gmail.com
Changelog