Refactor QbftExtraDataCodec from new instance to injection #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
jframe
reviewed
Aug 17, 2021
| @@ -47,6 +49,7 @@ | |||
| import com.google.common.collect.Lists; | |||
|
|
|||
| public class RoundSpecificPeers { | |||
| private static final BftExtraDataCodec bftExtraDataCodec = new QbftExtraDataCodec(); | |||
There was a problem hiding this comment.
Be better to pass in the constructor from TestContext so we can write PKI integration tests
...sus/qbft/src/test/java/org/hyperledger/besu/consensus/qbft/messagewrappers/ProposalTest.java
Show resolved
Hide resolved
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…er#2645) * Removed static codec on RoundChange * Removed static codec on ProposalPayload Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
RoundChangeandProposalPayloaddecode()methods to accept aBftExtraDataCodecimplementation (instead of creating a new instance ofQbftExtraDataCodec.QbftBesuControllerBuilder, where we choose the concrete codec instance to use.QbftExtraDataCodec(to keep the previous behaviour)fixes #2648
Changelog