Refactoring CmsValidator (internal CRL resolution) #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
lucassaldanha
force-pushed
the
CmsValidatorRefactor
branch
from
fe0b2f2 to
33acdfd
Compare
vmichalik
added
the
dev experience
jframe
reviewed
Aug 16, 2021
| @@ -178,4 +178,18 @@ private boolean isCertificateTrusted( | |||
| throw new RuntimeException("Error validating certificate chain", e); | |||
| } | |||
| } | |||
|
|
|||
| private Optional<CertStore> loadCRLs(final KeyStoreWrapper truststore) { | |||
There was a problem hiding this comment.
This isn't really loading CRL as such, maybe createCertStore?
| @@ -178,4 +178,18 @@ private boolean isCertificateTrusted( | |||
| throw new RuntimeException("Error validating certificate chain", e); | |||
| } | |||
| } | |||
|
|
|||
| private Optional<CertStore> loadCRLs(final KeyStoreWrapper truststore) { | |||
There was a problem hiding this comment.
Noticed there is CRLUtil that does something similar to this function, should that be used instead or this replaces that one?
There was a problem hiding this comment.
CRLUtil is used when loading the CRL pem file. Not for the truststore. They are similar but not the same.
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Refactoring CmsValidator (internal CRL resolution) Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Loading CRL list inside CmsValidator (instead of externally)
Changelog