Less Spotless Gradle Warnings #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotless and Gradle 7.x does not play nicely with using a fileTree as a target and should be using plain strings. This should get rid of the `Execution optimizations have been disabled`... warnings. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Generated reference test are currently generated into `src`, which is in violation of the standard maven layouts. They should be in the `build` directory as they are artifacts not maintained in source control. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
lucassaldanha
approved these changes
Aug 10, 2021
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Less Spotless Gradle Warnings Spotless and Gradle 7.x does not play nicely with using a fileTree as a target and should be using plain strings. This should get rid of the `Execution optimizations have been disabled`... warnings. * Move Generated Reference Tests into the `build` dir Generated reference test are currently generated into `src`, which is in violation of the standard maven layouts. They should be in the `build` directory as they are artifacts not maintained in source control. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Spotless and Gradle 7.x does not play nicely with using a fileTree as a
target and should be using plain strings. This should get rid of the
Execution optimizations have been disabled... warnings.Changelog