Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BFT validator RPCs to use validator provider #2592

Merged
merged 16 commits into from
Jul 30, 2021
Merged

BFT validator RPCs to use validator provider #2592

merged 16 commits into from
Jul 30, 2021

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Jul 28, 2021 •
edited
Loading

PR description

Update BFT rpcs for metrics, validators querying to use the validator provider so it will work with transaction based voting in qbft.

Fixed Issue(s)

Changelog

jframe added 14 commits July 22, 2021 14:42
@jframe
create validatorProvider facade to hide block specific validator voting
3aa868a 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
cleanup
d840152 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
Split voting out of ValidatorProvider and into VoteProvider so it can…
4017cfb 
… be optional

Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
rename package to validatorprovider
2dab45a 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
validate that voteprovider exists for protocols that require it
14eed22 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
rename package
7f8961b 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
Merge branch 'master' into bft_validator_provider
717627e
@jframe
spotless
af2ebfb 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
compile error
27b1e1c 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
validator query rpcs
59be758 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
Merge branch 'master' into validator_queries
731399f
@jframe
use Address for toString
2c1eaa4 
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe
Merge branch 'master' into validator_queries
8ff1db2
@jframe
Change getValidatorByBlock rpcs to get validators at the specified bl…
c6a1161 
…ock not the next block

Signed-off-by: Jason Frame <jasonwframe@gmail.com>
@jframe jframe requested a review from usmansaleem July 29, 2021 00:54
@jframe jframe added the TeamGroot GH issues worked on by Groot Team label Jul 29, 2021
usmansaleem
usmansaleem approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

usmansaleem
usmansaleem approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jframe jframe merged commit 63468d8 into hyperledger:master Jul 30, 2021
@jframe jframe deleted the validator_queries branch July 30, 2021 02:39
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@jframe @eum602
BFT validator RPCs to use validator providers so that they will work …
16a24a7 
…with qbft voting changes (hyperledger#2592)

Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usmansaleem usmansaleem usmansaleem approved these changes

Assignees
No one assigned
Labels
TeamGroot GH issues worked on by Groot Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jframe @usmansaleem