Prioritize with nonce distance #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkt
requested changes
Jul 7, 2021
...um/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/PendingTransactions.java
Outdated
Show resolved
Hide resolved
...um/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/PendingTransactions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
…ort keys aren't working as I expect Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
…l check for dropping Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
…ders Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
jflo
force-pushed
the
prioritize-with-nonce-distance
branch
from
e5a4b55 to
d6162a9
Compare
|
Waiting till after london to merge, and then observe running for a while. |
garyschulte
reviewed
Aug 12, 2021
| @@ -436,7 +432,7 @@ public void transactionDroppedEventDoesNotFireAfterUnsubscribe() { | |||
| transactionPool.addLocalTransaction(TX2); | |||
|
|
|||
| assertThat(result.get()).isNotNull(); | |||
| serviceImpl.removeTransactionAddedListener(id); | |||
| serviceImpl.removeTransactionDroppedListener(id); | |||
garyschulte
added a commit
to garyschulte/besu
that referenced
this pull request
Sep 1, 2021
This reverts commit 1f4f131.
1 task
garyschulte
added a commit
to garyschulte/besu
that referenced
this pull request
Sep 1, 2021
Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Justin Florentine <justin.florentine@consensys.net> Co-authored-by: matkt <karim.t2am@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Prevent multiple transactions from the same address from evicting others which are waiting in a full transaction pool. When we have to evict a transaction from a full pool, we now also consider how far it is from the lowest nonce from the same address already in the pool. We are also increasing the size of the pending transaction pool, so it should support the new 10MB maximum message size previously introduced by pr #2485 .
Fixed Issue(s)
Changelog
Default value for
--tx-pool-max-sizeis now 32K.