Implement eth_getBlockByNumber while downloading state. #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Florentine <justin.florentine@consensys.net> (cherry picked from commit f7d5055)
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net> (cherry picked from commit faf8d05)
Signed-off-by: Justin Florentine <justin.florentine@consensys.net> (cherry picked from commit 8f86832)
Signed-off-by: Justin Florentine <justin.florentine@consensys.net> (cherry picked from commit 196d3ee)
Signed-off-by: Justin Florentine <jflorentine@gmail.com> (cherry picked from commit 0ae0e0c)
Signed-off-by: Justin Florentine <jflorentine@gmail.com> (cherry picked from commit f531299)
Signed-off-by: Justin Florentine <jflorentine@gmail.com> (cherry picked from commit d40cdee)
Signed-off-by: Justin Florentine <jflorentine@gmail.com> (cherry picked from commit 241eb53)
Signed-off-by: Justin Florentine <justin.florentine@consensys.net> (cherry picked from commit 6e49458)
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Signed-off-by: Justin Florentine <jflorentine@gmail.com> (cherry picked from commit 0ba36b4)
Signed-off-by: Justin Florentine <jflorentine@gmail.com>
Signed-off-by: Justin Florentine <jflorentine@gmail.com> (cherry picked from commit f2b5ac6)
Signed-off-by: Justin Florentine <jflorentine@gmail.com> (cherry picked from commit 337198b)
Signed-off-by: Justin Florentine <jflorentine@gmail.com> (cherry picked from commit d187e4c)
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
|
Hey @jflo, it would be useful for posterity to have a descriptive PR title. How about "Implement correct behavior of eth_getBlockByNumber"? |
matkt
reviewed
Jun 28, 2021
...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetBlockByNumber.java
Outdated
Show resolved
Hide resolved
ethereum/retesteth/src/main/java/org/hyperledger/besu/ethereum/retesteth/DummySynchronizer.java
Show resolved
Hide resolved
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
RatanRSur
pushed a commit
to RatanRSur/besu
that referenced
this pull request
Jul 8, 2021
…2481) Introduces a dependency from eth_getBlockByNumber onto the Synchronizer, in order to determine download state, and current most recent block that we have state for. JsonRPC test classes also were refactored to provide a Synchronizer. Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
RatanRSur
pushed a commit
to RatanRSur/besu
that referenced
this pull request
Jul 8, 2021
…2481) Introduces a dependency from eth_getBlockByNumber onto the Synchronizer, in order to determine download state, and current most recent block that we have state for. JsonRPC test classes also were refactored to provide a Synchronizer. Signed-off-by: Justin Florentine <justin.florentine@consensys.net> Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
RatanRSur
pushed a commit
to RatanRSur/besu
that referenced
this pull request
Jul 8, 2021
…2481) Introduces a dependency from eth_getBlockByNumber onto the Synchronizer, in order to determine download state, and current most recent block that we have state for. JsonRPC test classes also were refactored to provide a Synchronizer. Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
RatanRSur
pushed a commit
to RatanRSur/besu
that referenced
this pull request
Jul 8, 2021
…2481) Introduces a dependency from eth_getBlockByNumber onto the Synchronizer, in order to determine download state, and current most recent block that we have state for. JsonRPC test classes also were refactored to provide a Synchronizer. Signed-off-by: Justin Florentine <justin.florentine@consensys.net> Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…2481) Introduces a dependency from eth_getBlockByNumber onto the Synchronizer, in order to determine download state, and current most recent block that we have state for. JsonRPC test classes also were refactored to provide a Synchronizer. Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Introduces a dependency from eth_getBlockByNumber onto the Synchronizer, in order to determine download state, and current most recent block that we have state for. JsonRPC test classes also were refactored to provide a Synchronizer.
Fixed Issue(s)
fixes #2209
Changelog
When asking for the latest block while downloading state, will return most recent block we have state for. While still downloading block headers, will return genesis block.