Bft messages have duplicate prepares in roundChange message #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
jframe
changed the title
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
…change' into qbft_duplicate_prepares_in_roundchange
jframe
added a commit
to jframe/besu
that referenced
this pull request
Jun 22, 2021
…perledger#2449) Signed-off-by: Jason Frame <jasonwframe@gmail.com>
jframe
added a commit
that referenced
this pull request
Jun 22, 2021
) (#2459) Signed-off-by: Jason Frame <jasonwframe@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 25, 2021
…perledger#2449) Signed-off-by: Jason Frame <jasonwframe@gmail.com>
RatanRSur
pushed a commit
to RatanRSur/besu
that referenced
this pull request
Jul 8, 2021
…perledger#2449) (hyperledger#2459) Signed-off-by: Jason Frame <jasonwframe@gmail.com> Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…perledger#2449) Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
In IBFT2 and QBFT the round change message could be created with duplicate prepares being included in the round change message. These messages are rejected as being invalid by Besu.
This fixes the equality and hashCode on the message so that we don't add duplicate messages.
Fixed Issue(s)
Changelog