eth_getCode: add support for GoQuorum private tx #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* eth_getCode try to get from private state first Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * add container test for eth_getCode Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to retrieve from GoQuorum private state first, otherwise get from public state as before.
I have tested this by:
Node1 deploys a contract, private for Node4. Nodes 1 and 4 can get the code; Nodes 2 and 3 do not. getCode for public tx works as before (all nodes get the right value). Attempting to getCode for non-existent address gives 0x.
Changelog