Fix consensus vulnerability regarding excessively large 1559 fee fields #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
garyschulte
reviewed
May 28, 2021
There was a problem hiding this comment.
Do we need to update MainnetBlockBodyValidator.validateTransactionGasPrice also for blocks that are imported or synced ? TransactionDecoder should handle case 1 & 2, I presume case 4 is handled by actually executing the transaction, but I don't see a code path that checks for # 3 for imported blocks.
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/encoding/TransactionDecoder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
garyschulte
reviewed
May 28, 2021
...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidator.java
Show resolved
Hide resolved
Ah nvm, it looks like we call validateTransaction in processBlock -> processTransaction |
lucassaldanha
pushed a commit
to lucassaldanha/besu
that referenced
this pull request
May 31, 2021
…ds (hyperledger#2338) based on: ethereum/pm#321 (comment) Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…ds (hyperledger#2338) based on: ethereum/pm#321 (comment) Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
ethereum/pm#321 (comment)
Changelog