Fix SECP256R1AcceptanceTest #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y use it when the nodes are started as their own processes Signed-off-by: Daniel Lehrner <daniel@io.builders>
macfarla
approved these changes
May 25, 2021
| throw new IllegalArgumentException("Cannot store generated private key."); | ||
| } | ||
| } | ||
|
|
||
| public static File getDefaultKeyFile(final Path homeDirectory) { |
There was a problem hiding this comment.
I'd also rename this one s/homeDirectory/directory
| final File privateKeyDir = file.getParentFile(); | ||
| privateKeyDir.mkdirs(); | ||
| final Path tempPath = Files.createTempFile(privateKeyDir.toPath(), ".tmp", ""); | ||
| Files.write( | ||
| tempPath, | ||
| keyKair.getPrivateKey().getEncodedBytes().toString().getBytes(StandardCharsets.UTF_8)); | ||
| keyPair.getPrivateKey().getEncodedBytes().toString().getBytes(StandardCharsets.UTF_8)); |
| } | ||
|
|
||
| private KeyPair createKeyPair(final String privateKey) { | ||
| return SIGNATURE_ALGORITHM.createKeyPair( |
There was a problem hiding this comment.
might be clearer to name this SECP256R1_ SIGNATURE_ALGORITHM
Signed-off-by: Daniel Lehrner <daniel@io.builders>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 17, 2021
* don't set SECP256R1 as signature algorithm instance in the tests, only use it when the nodes are started as their own processes Signed-off-by: Daniel Lehrner <daniel@io.builders> * renamed some variables for better readability Signed-off-by: Daniel Lehrner <daniel@io.builders>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* don't set SECP256R1 as signature algorithm instance in the tests, only use it when the nodes are started as their own processes Signed-off-by: Daniel Lehrner <daniel@io.builders> * renamed some variables for better readability Signed-off-by: Daniel Lehrner <daniel@io.builders>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Lehrner daniel@io.builders
PR description
SECP256R1AcceptanceTest needed to set
SECP256R1as signature algorithm instance. Because this variable is static and is used inBesuNodeto create a key pair it could happen that other tests were using the SECP256R1 signature algorithm by accident becuase of this, depending on the order in which the tests were executed. This caused the acceptance tests to be flaky.This PR introduces the possibility to set a pre-generated key pair in
BesuNodeFactory. This allows to set a SECP256R1 key pair without changingSignatureAlgorithmFactory.instance, which avoids that other tests can happen to use SECP256R1 when they expect SECP256K1.Fixed Issue(s)
reintroduces test which was ignored in #2267
Changelog