Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SECP256R1 support to CLI sub command generate-blockchain-config #2183

Conversation

daniel-iobuilders
Copy link
Contributor

Support for secp256r1 is added to the CLI sub command generate-blockchain-config. The command checks if the genesis property of the configuration file has a field ecCurve. This field is used to select the alternative signature algorithm secp256r1. If secp256r1 is indeed set, the public keys in extraData are generated using this signature algorithm. In any other case the default signature algorithm is used.
If the public keys are already provided in the blockchain property of the configuration file, it is verified if those keys are valid for the selected signature algorithm. This avoids that a user error could generate a genesis file with invalid keys.

Fixed Issue(s)

Fixes #2182

Changelog

@daniel-iobuilders daniel-iobuilders changed the title Generate blockchain config secp256r1 Add SECP256R1 support to CLI sub command generate-blockchain-config Apr 22, 2021
Signed-off-by: Daniel Lehrner <daniel@io.builders>
@daniel-iobuilders daniel-iobuilders force-pushed the generate_blockchain_config_secp256r1 branch from 5d1ddd2 to aeff703 Compare April 22, 2021 20:58
@lucassaldanha lucassaldanha enabled auto-merge (squash) April 27, 2021 20:25
@lucassaldanha lucassaldanha self-assigned this Apr 27, 2021
@lucassaldanha lucassaldanha merged commit 456981c into hyperledger:master Apr 27, 2021
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SECP256R1 support to CLI sub command generate-blockchain-config
2 participants