-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for 1559 in retesteth besu command #2181
add support for 1559 in retesteth besu command #2181
Conversation
@@ -132,6 +134,19 @@ private static String modifyGenesisFile(final String initialGenesis) { | |||
maybeMove(genesis, "timestamp", chainParamsJson, "timestamp"); | |||
maybeMove(chainParamsJson, "accounts", chainParamsJson, "alloc"); | |||
|
|||
if (ExperimentalEIPs.eip1559Enabled) { | |||
// TODO EIP-1559 change for the actual fork name when known | |||
maybeMoveToNumber(params, "londonForkBlock", config, "aleutBlock"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this rpc endpoint is expecting londonForkBlock in order to conform with existing precedent, but is mapping it to aleutBlock since that is what we currently have in master for the 1559 fork block config name (though it definitely will change)
Head branch was pushed to by a user without write access
enable 1559 to start at genesis Signed-off-by: garyschulte <garyschulte@gmail.com>
…nesis Signed-off-by: garyschulte <garyschulte@gmail.com>
…an be mapped to null Signed-off-by: garyschulte <garyschulte@gmail.com>
this PR breaks backwards compatibility
|
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte garyschulte@gmail.com
PR description
This pr kicks the can down the road for 2 things:
the first is NBD, but we might want to incorporate baseFee in genesis config at some point. Probably once we move 1559 out of 'experimental' status.
Fixed Issue(s)
fixes #2180
Changelog