Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 1559 in retesteth besu command #2181

Merged
merged 4 commits into from
Apr 23, 2021
Merged

add support for 1559 in retesteth besu command #2181

merged 4 commits into from
Apr 23, 2021

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Apr 21, 2021

Signed-off-by: garyschulte garyschulte@gmail.com

PR description

  • add support for 1559 in test_setChainParams
  • add a "1559 at genesis" provision

This pr kicks the can down the road for 2 things:

  • hardfork naming
  • 1559 baseFee as a part of genesis json configuration

the first is NBD, but we might want to incorporate baseFee in genesis config at some point. Probably once we move 1559 out of 'experimental' status.

Fixed Issue(s)

fixes #2180

Changelog

@@ -132,6 +134,19 @@ private static String modifyGenesisFile(final String initialGenesis) {
maybeMove(genesis, "timestamp", chainParamsJson, "timestamp");
maybeMove(chainParamsJson, "accounts", chainParamsJson, "alloc");

if (ExperimentalEIPs.eip1559Enabled) {
// TODO EIP-1559 change for the actual fork name when known
maybeMoveToNumber(params, "londonForkBlock", config, "aleutBlock");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rpc endpoint is expecting londonForkBlock in order to conform with existing precedent, but is mapping it to aleutBlock since that is what we currently have in master for the 1559 fork block config name (though it definitely will change)

@RatanRSur RatanRSur enabled auto-merge (squash) April 21, 2021 22:48
auto-merge was automatically disabled April 21, 2021 23:42

Head branch was pushed to by a user without write access

enable 1559 to start at genesis

Signed-off-by: garyschulte <garyschulte@gmail.com>
…nesis

Signed-off-by: garyschulte <garyschulte@gmail.com>
…an be mapped to null

Signed-off-by: garyschulte <garyschulte@gmail.com>
@matkt matkt merged commit 089bfab into hyperledger:master Apr 23, 2021
@winsvega
Copy link

winsvega commented Apr 25, 2021

this PR breaks backwards compatibility

Request: {"jsonrpc":"2.0","method":"test_setChainParams","params":[{
    "params" : {
        "homesteadForkBlock" : "0x00",
        "EIP150ForkBlock" : "0x00",
        "EIP158ForkBlock" : "0x00",
        "byzantiumForkBlock" : "0x00",
        "constantinopleForkBlock" : "0x00",
        "constantinopleFixForkBlock" : "0x00",
        "istanbulForkBlock" : "0x00",
        "berlinForkBlock" : "0x00",
        "chainID" : "0x01"
    },
    "accounts" : {
        "0x095e7baea6a6c7c4c2dfeb977efac326af552d87" : {
            "balance" : "0x0de0b6b3a7640000",
            "code" : "0x600160010160005500",
            "nonce" : "0x00",
            "storage" : {
            }
        },
        "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b" : {
            "balance" : "0x0de0b6b3a7640000",
            "code" : "0x",
            "nonce" : "0x00",
            "storage" : {
            }
        }
    },
    "sealEngine" : "NoReward",
    "genesis" : {
        "author" : "0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba",
        "difficulty" : "0x020000",
        "gasLimit" : "0xff112233445566",
        "extraData" : "0x00",
        "timestamp" : "0x00",
        "nonce" : "0x0000000000000000",
        "mixHash" : "0x0000000000000000000000000000000000000000000000000000000000000000"
    }
}],"id":1}
Reply: `{
  "jsonrpc" : "2.0",
  "id" : 1,
  "result" : false
}`

eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 1559 params in test_setChainParams rpc endpoint
4 participants