Shutdown vertx instance created within BesuCommand #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… doesn't leak file descriptors. Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
rojotek
approved these changes
Nov 21, 2019
|
This change appears to fix the test on my machine - iMac 2019. I do reproduce the problem on the master branch. |
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
… doesn't leak file descriptors. (hyperledger#209) Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
… doesn't leak file descriptors. (hyperledger#209) Signed-off-by: Adrian Sutton <adrian.sutton@consensys.net> Signed-off-by: edwardmack <ed@edwardmack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
BesuCommandTestand probably anything else that extendsCommandTestAbstractleaked about 50 file descriptors per test that successfully parsed the CLI args.BesuCommandcreates aVertxinstance which is never shutdown.This is the root cause of newer Macs failing tests with "Failed to create a child event loop". They have more cores so run more processes in parallel which increases the number of file descriptors validly being used (each process needs around 200 file descriptors) and increases the chance that two of these tests will run at the same time and hit the resource limits.
This is a fairly brute-force approach to getting hold of that vertx instance and shutting it down but it solves the immediate issue.
Signed-off-by: Adrian Sutton adrian.sutton@consensys.net