Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BftBlockInterface#replaceRoundInBlock non-static #2067

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

lucassaldanha
Copy link
Member

PR description

Make BftBlockInterface#replaceRoundInBlock non-static

Changelog

Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
@lucassaldanha lucassaldanha requested a review from jframe March 24, 2021 01:00
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha enabled auto-merge (squash) March 24, 2021 03:26
@lucassaldanha lucassaldanha merged commit 3ce42a3 into hyperledger:master Mar 24, 2021
@lucassaldanha lucassaldanha deleted the remove-static branch March 24, 2021 03:38
RichardH92 pushed a commit to RichardH92/besu that referenced this pull request Mar 29, 2021
* Make BftBlockInterface#replaceRoundInBlock non-static

Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Richard Hart <richardhart92@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* Make BftBlockInterface#replaceRoundInBlock non-static

Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants