Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 3 maintainers to Emeritus status. #2048

Merged
merged 6 commits into from
Apr 6, 2021

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Mar 20, 2021

I propose moving the following maintainers to Emeritus status, pursuant to the inactivity clause. Since this is the first such proposal I am extending the window so that two reporting quarters of inactivity be required for movement to Emeritus. (28 Sep 2020 was the start of the Q4 report)

  • @iikirilov's last commit was on 24 Mar 2020
  • @CjHare's last commit was on 5 Mar 2020
  • @rojotek's last commit was on 7 Oct 2019

We very much appreciate their contributions but moving their status to emeritus (and thus revoking PR approval privileges) is in the interest of an orderly project. If any of these maintainers express in this PR that the intend to make contributions in the next quarter then they will not be moved to emeritus status.

I propose this vote is open until either an absolute majority of active maintainers (11) votes for the same outcome, or until two weeks has passed (3 April 2021), after which a voting majority will determine the outcome (with a tie resulting in no change).

(edit: @mbaxter was on the original list but (a) has had comments in the past two quarters, which my tooling didn't pick up and (b) has expressed a desire to stay active and contribute. Each reason is independently sufficient.)

Move four maintainers who have not authored commits in the last 6 months
to Emeretus status.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
@shemnon
Copy link
Contributor Author

shemnon commented Mar 20, 2021

As the author of the PR, this is my obligatory +1 vote.

Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per Hyperledger charter. Thank you for your contributions and hopefully to more soon!

Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except for @mbaxter.

@mbaxter
Copy link
Contributor

mbaxter commented Mar 21, 2021

I actually have some more recent code review activity, so I'm not sure I fall into this bucket. In any case, I'd like to stay active and I'll try to step up my contributions.

@ajsutton
Copy link
Contributor

I agree we should value code reviews and other forms of participation, not just commits so would be against this change including Meredith.

I'm +1 on moving the other three to emeritus status.

@shemnon
Copy link
Contributor Author

shemnon commented Mar 21, 2021

The reporting I have just has commits. I'll gather a list of code reviews in a few days (tooling...). Per existing maintainer policies reviews do count for activity.

Per @mbaxter's statement I will also remove that particular proposal and reduce the list to 3.

@rojotek
Copy link
Contributor

rojotek commented Mar 21, 2021

As one of the 3 potential contributors moving to an emeritus status, I fully support this 😄

@timbeiko
Copy link
Contributor

@shemnon could you add me to this list? I haven't had a significant commit in some time (even including docs). I don't think I should have approve privileges, and am happy to open PRs as needed in the future.

@shemnon
Copy link
Contributor Author

shemnon commented Mar 24, 2021

Keeping the Changelog up to date is significant enough. Since this is a self-nomination I will create a separate PR so there is one PR per cause of action.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
@shemnon shemnon changed the title Move 4 maintainers to Emeritus status. Move 3 maintainers to Emeritus status. Mar 24, 2021
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemnon
Copy link
Contributor Author

shemnon commented Apr 6, 2021

There were no objections to three of the maintainers being moved to emeritus. One maintainer's change of status had an objection and it was was sustained and will not be moved to emeritus.

@shemnon shemnon enabled auto-merge (squash) April 6, 2021 19:11
@shemnon shemnon merged commit e31f614 into hyperledger:master Apr 6, 2021
@shemnon shemnon deleted the emeritus21Q1 branch February 26, 2022 18:44
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Move inactive maintainers to Emeritus status.

Move three maintainers to Emeritus status.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.