Cache MessageDigests #1984
Merged
Cache MessageDigests #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetching the hash from the java security providers is often longer than the hashing itself, so we should cache results from the providers in a reusable fashion. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
|
This will eliminate ~10% of the time wasted in mainnet block processing. More time was spent fetching the hash algo then actually executing it. |
RatanRSur
reviewed
Mar 6, 2021
Comment on lines
+34
to
+41
| private static final Supplier<MessageDigest> KECCAK256_SUPPLIER = | ||
| Suppliers.memoize(() -> messageDigest(KECCAK256_ALG)); | ||
| private static final Supplier<MessageDigest> SHA256_SUPPLIER = | ||
| Suppliers.memoize(() -> messageDigest(SHA256_ALG)); | ||
| private static final Supplier<MessageDigest> RIPEMD160_SUPPLIER = | ||
| Suppliers.memoize(() -> messageDigest(RIPEMD160_ALG)); | ||
| private static final Supplier<MessageDigest> BLAKE2BF_SUPPLIER = | ||
| Suppliers.memoize(() -> messageDigest(BLAKE2BF_ALG)); |
There was a problem hiding this comment.
How do you feel about just initializing these statically instead of using Suppliers?
There was a problem hiding this comment.
The security providers may not be properly set up when the class initializes.
For example, the blake2f provider is loaded via besu code on startup, and since the algorithms are loaded by string reference the code that adds blake2f to the providers is not guaranteed to have run since there is no class file dependency. And this is the wrong place to do that provider setup.
RatanRSur
approved these changes
Mar 10, 2021
RichardH92
pushed a commit
to RichardH92/besu
that referenced
this pull request
Mar 29, 2021
Fetching the hash from the java security providers is often longer than the hashing itself, so we should cache results from the providers in a reusable fashion. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: Richard Hart <richardhart92@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Fetching the hash from the java security providers is often longer than the hashing itself, so we should cache results from the providers in a reusable fashion. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching the hash from the java security providers is often longer than
the hashing itself, so we should cache results from the providers in a
reusable fashion.
Signed-off-by: Danno Ferrin danno.ferrin@gmail.com
Changelog