Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce hash calculations in Bonsai Tries #1960

Merged
merged 3 commits into from
Mar 1, 2021

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Feb 28, 2021

Setting contract code on a bonsai account results in a re-hashing. To
reduce this only set the code if the code was changed. In some cases
this was responsible for 40% of load.

Signed-off-by: Danno Ferrin danno.ferrin@gmail.com

Changelog

Setting contract code on a bonsai account results in a re-hashing. To
reduce this only set the code if the code was changed.  In some cases
this was responsible for 40% of load.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Copy link
Contributor

@matkt matkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemnon shemnon merged commit 2e87576 into hyperledger:master Mar 1, 2021
RichardH92 pushed a commit to RichardH92/besu that referenced this pull request Mar 29, 2021
Setting contract code on a bonsai account results in a re-hashing. To
reduce this only set the code if the code was changed.  In some cases
this was responsible for 40% of load.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Richard Hart <richardhart92@gmail.com>
@shemnon shemnon deleted the holdTheHash branch February 26, 2022 18:44
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Setting contract code on a bonsai account results in a re-hashing. To
reduce this only set the code if the code was changed.  In some cases
this was responsible for 40% of load.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants